Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Scan The QR Code in Asset Module #7571

Closed
gayann-au opened this issue Apr 8, 2024 · 4 comments · Fixed by #7588 or #7617
Closed

Unable to Scan The QR Code in Asset Module #7571

gayann-au opened this issue Apr 8, 2024 · 4 comments · Fixed by #7588 or #7617
Assignees
@AnkurPrabhu
Labels
bug Something isn't working

Comments

@gayann-au
Copy link

gayann-au commented Apr 8, 2024 •
edited
Loading

Unable to Scan the QR Codes in the assets Module in Windows 11,Mac,iOS irrespective of any Browsers used. error Messages are popped as soon as the QR Code is scanned and detected. The Snapshot of the Error Message is pasted below

Screenshot 2024-04-08 173142
@github-project-automation github-project-automation bot moved this to Triage in Care Apr 8, 2024
@rithviknishad rithviknishad added the bug Something isn't working label Apr 10, 2024
@AnkurPrabhu
Copy link
Contributor

@rithviknishad I found the root cause

@AnkurPrabhu
Copy link
Contributor

fixing it and raising a pr

@AnkurPrabhu AnkurPrabhu mentioned this issue Apr 11, 2024
Merged
6 tasks
@AnkurPrabhu
Copy link
Contributor

AnkurPrabhu commented Apr 11, 2024 •
edited
Loading

@rithviknishad here is the pr, can you tell me how can i test it locally for valid QR codes

@Ashesh3 Ashesh3 mentioned this issue Apr 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from Triage to Done in Care Apr 15, 2024
@AnkurPrabhu
Copy link
Contributor

AnkurPrabhu commented Apr 15, 2024 •
edited
Loading

@khavinshankar @Ashesh3 my changes are to handle invalid qr code
currently the page starts infinite loading if a wrong QR code is sent
and notification says something went wrong

before

Screenshot 2024-04-16 at 12 22 17 AM

after
Screenshot 2024-04-16 at 12 26 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnkurPrabhu AnkurPrabhu

Labels
bug Something isn't working
Projects
Care
Archived in project
Milestone
No milestone
3 participants
@rithviknishad @AnkurPrabhu @gayann-au