Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves discharged tab switch behaviour #7358

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 7, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner March 7, 2024 14:56
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 10:02am

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7a51d24
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65f9625f69e02c0008318a7c
😎 Deploy Preview https://deploy-preview-7358--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Mar 7, 2024

Passing run #2274 ↗︎

0 114 0 0 Flakiness 0

Details:

Improves discharged tab switch behaviour
Project: CARE Commit: 7a51d24982
Status: Passed Duration: 03:10 💡
Started: Mar 19, 2024 10:05 AM Ended: Mar 19, 2024 10:08 AM

Review all test suite changes for PR #7358 ↗︎

@rithviknishad
Copy link
Member Author

TODO:

  • show tab switch if these conditions are not met. instead suggest user to select a facility using popup

@rithviknishad
Copy link
Member Author

TODO: show notification/info about why user is required to select a facility

@rithviknishad rithviknishad changed the title Show Live/Discharged tab for patient list when single facility is accessible or filtered. Improved workflow on how discharged tab is accessed and bring back Show Live/Discharged tab for all users Mar 12, 2024
@rithviknishad rithviknishad changed the title Improved workflow on how discharged tab is accessed and bring back Show Live/Discharged tab for all users Improves discharged tab switch behaviour Mar 18, 2024
@rithviknishad
Copy link
Member Author

@nihal467

@aparnacoronasafe aparnacoronasafe added the P1 breaking issue or vital feature label Mar 18, 2024
@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Mar 19, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4cea768 into develop Mar 19, 2024
63 of 64 checks passed
@khavinshankar khavinshankar deleted the discharged-facility-enhancements branch March 19, 2024 11:40
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature reviewed reviewed by a core member tested
Projects
None yet
5 participants