-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-close dropdown when single select option is selected in a multi select dropdown #7253
Auto-close dropdown when single select option is selected in a multi select dropdown #7253
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @UdaySagar-Git 🚀
Could we make it like
- When asymptomatic is selected, close the dropdown as the user will not select any more options.
- But when asymptomatic is unselected, keep the dropdown opened, as the user is expected to continue by selecting one or more symptoms.
Screencast.from.23-02-24.11.52.34.AM.IST.webm@rithviknishad I hope this fixes the issue , let me know if it requires any more changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
@UdaySagar-Git the cypress test is failing, can you fix it |
@nihal467 https://github.com/coronasafe/care_fe/blob/bda15df327003b9bf741edc004fe1eb5d111f463/cypress/e2e/patient_spec/patient_consultation.cy.ts#L22 |
@UdaySagar-Git to run the cypress locally, you'll have to run the backend locally too and load the dummy data onto it. And connect your local FE to the local BE to run cypress |
@nihal467 can you please help me fix this |
@UdaySagar-Git i will look into it, and will let you know by tomorrow EOD |
@UdaySagar-Git the failing test is due to a frontend bug in the staging, upon merging ( #7257 ) tomorrow morning will fix the test |
@nihal467 sure ! |
LGTM |
@UdaySagar-Git Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Before :
After :
Screencast.from.23-02-24.04.01.34.AM.IST.webm
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers