-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache only the advance filters #6988
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM.
Except skip keeping cacheBlacklist as an arg of updateFiltersCache.
Instead:
- Skip passing cacheBlacklist as an arg to updateFitlersCache, there's no need for it to sit there.
- Concat the cache blacklist outside the updateFiltersCache, because you need not keep concating everytime the function is invoked, you can just execute it while the useFilters hook runs.
@rithviknishad is this okay or are there any changes |
👋 Hi, @AshrafMd-1, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@AshrafMd-1 was the filters cache working in your PR? How were you able to test whether this PR was working or not? |
It wasn't working. Even when I tested it |
👋 Hi, @AshrafMd-1, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@AshrafMd-1 fix the cypress test |
@AshrafMd-1 the lint checks are failing |
@rithviknishad @nihal467 done |
LGTM |
@AshrafMd-1 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist