Timeline style view for Daily Rounds #6808

Pranshu1902 · 2023-12-07T15:41:43Z

WHAT

`🤖[deprecated] Generated by Copilot at f0ee615`

Refactored the UI and code of the daily rounds feature for patients in a facility. Used the Timeline and TimelineNode components to display the daily rounds as a chronological sequence of events. Simplified the DefaultLogUpdateCard and VirtualNursingAssistantLogUpdateCard components to show only the relevant information and actions for each round. Removed unused code and components.

Proposed Changes

Fixes Timeline style view for Daily Rounds #6770
Use Timeline style component for displaying the Update Logs of Daily Rounds

Now:

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

HOW

`🤖[deprecated] Generated by Copilot at f0ee615`

Remove unused components and variables from DefaultLogUpdateCard and VirtualNursingAssistantLogUpdateCard components (link, link, link, link, link, link)
Replace PaginatedList with Timeline and TimelineNode components to render daily rounds list as a chronological sequence of events in DailyRoundsList component (link, link)
Move buttons to view details and update log from DailyRoundsList to DefaultLogUpdateCard component (link, link)

vercel · 2023-12-07T15:41:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2023 8:57am

netlify · 2023-12-07T15:41:50Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`ada6efd`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/658943daa1be010008e4c8c1
😎 Deploy Preview	https://deploy-preview-6808--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Pranshu1902 · 2023-12-07T15:42:22Z

@rithviknishad @khavinshankar @nihal467 @gigincg any recommendations on the designs?

src/Components/Facility/Consultations/DailyRoundsList.tsx

src/Components/Facility/Consultations/DailyRounds/DefaultLogUpdateCard.tsx

Co-authored-by: Rithvik Nishad <[email protected]>

…dateCard.tsx Co-authored-by: Rithvik Nishad <[email protected]>

src/Components/Facility/Consultations/DailyRoundsList.tsx

Co-authored-by: Rithvik Nishad <[email protected]>

Pranshu1902 · 2023-12-07T16:11:33Z

@rithviknishad should we add some padding?

rithviknishad · 2023-12-07T16:12:20Z

Yes, also the user icon itself would be good here ig. What do you think?

Pranshu1902 · 2023-12-07T16:13:06Z

How do I add the user icon? The Timeline component is automatically taking the firstname and lastname to display

rithviknishad · 2023-12-07T16:13:08Z

Have a gray border maybe for the details part like the green border is there for the details part of automated rounds

src/Components/Facility/Consultations/DailyRoundsList.tsx

Pranshu1902 · 2023-12-07T16:19:12Z

Updated view:

github-actions · 2023-12-20T14:19:49Z

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 · 2023-12-20T14:21:29Z

@Pranshu1902 clear the merge conflict for testing

Pranshu1902 · 2023-12-24T20:41:56Z

@nihal467 done
Updated view:

Loader:

nihal467 · 2023-12-27T14:01:38Z

LGTM

Pranshu1902 · 2023-12-27T14:11:49Z

Also Fixes #6886

github-actions · 2023-12-28T01:08:37Z

@Pranshu1902 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

* make template timeline design * Update src/Components/Facility/Consultations/DailyRoundsList.tsx Co-authored-by: Rithvik Nishad <[email protected]> * Update src/Components/Facility/Consultations/DailyRoundsList.tsx Co-authored-by: Rithvik Nishad <[email protected]> * Update src/Components/Facility/Consultations/DailyRoundsList.tsx Co-authored-by: Rithvik Nishad <[email protected]> * Update src/Components/Facility/Consultations/DailyRounds/DefaultLogUpdateCard.tsx Co-authored-by: Rithvik Nishad <[email protected]> * Update src/Components/Facility/Consultations/DailyRounds/DefaultLogUpdateCard.tsx Co-authored-by: Rithvik Nishad <[email protected]> * Update src/Components/Facility/Consultations/DailyRoundsList.tsx Co-authored-by: Rithvik Nishad <[email protected]> * add border and user icon * refactor * always display time on right * use measured at time instead of created at * enhance UI spacing * show user type and fix tooltip * enhance the loader * refactor * complete merge * remove empty card in loader --------- Co-authored-by: Rithvik Nishad <[email protected]> Co-authored-by: Aakash Singh <[email protected]>

rithviknishad · 2024-01-30T03:29:31Z

src/CAREUI/misc/PaginatedList.tsx

+    <Timeline className="rounded-lg bg-white p-2 shadow" name="log update">
+      <ul className={props.className}>
+        {loading && props.shimmer
+          ? Array.from({ length: props.shimmerCount ?? 8 }).map((_, i) => (
+              <li key={i} className="w-full">
+                {props.shimmer}
+              </li>
+            ))
+          : items.map((item, index, items) => (
+              <li key={index} className="w-full">
+                {props.children(item, items)}
+              </li>
+            ))}
+      </ul>
+    </Timeline>


PagiantedList is a generic reusable component. Wrapping timeline here is not appropriate. Because not all Paginated List Items are Timelines, although all Timelines may be Paginated List Items.

make template timeline design

f0ee615

Pranshu1902 added the work-in-progress label Dec 7, 2023

Pranshu1902 requested a review from a team as a code owner December 7, 2023 15:41

vercel bot temporarily deployed to Preview December 7, 2023 15:42 Inactive

rithviknishad reviewed Dec 7, 2023

View reviewed changes

Pranshu1902 and others added 5 commits December 7, 2023 21:37

Update src/Components/Facility/Consultations/DailyRoundsList.tsx

8958880

Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Facility/Consultations/DailyRoundsList.tsx

5a279d7

Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Facility/Consultations/DailyRoundsList.tsx

c74ff1a

Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Facility/Consultations/DailyRounds/DefaultLogUp…

2f19d1d

…dateCard.tsx Co-authored-by: Rithvik Nishad <[email protected]>

Update src/Components/Facility/Consultations/DailyRounds/DefaultLogUp…

da177c8

…dateCard.tsx Co-authored-by: Rithvik Nishad <[email protected]>

rithviknishad reviewed Dec 7, 2023

View reviewed changes

src/Components/Facility/Consultations/DailyRoundsList.tsx Outdated Show resolved Hide resolved

Update src/Components/Facility/Consultations/DailyRoundsList.tsx

e7a8eb6

Co-authored-by: Rithvik Nishad <[email protected]>

vercel bot temporarily deployed to Preview December 7, 2023 16:10 Inactive

rithviknishad reviewed Dec 7, 2023

View reviewed changes

src/Components/Facility/Consultations/DailyRoundsList.tsx Outdated Show resolved Hide resolved

rithviknishad reviewed Dec 7, 2023

View reviewed changes

src/Components/Facility/Consultations/DailyRoundsList.tsx Outdated Show resolved Hide resolved

add border and user icon

fb01e12

vercel bot temporarily deployed to Preview December 7, 2023 16:19 Inactive

refactor

417e3e9

Pranshu1902 added needs testing and removed work-in-progress labels Dec 7, 2023

vercel bot temporarily deployed to Preview December 7, 2023 16:22 Inactive

always display time on right

fb7a496

rithviknishad approved these changes Dec 19, 2023

View reviewed changes

Merge branch 'develop' into issue#6770

59d9d2a

Pranshu1902 added needs testing and removed discussion required labels Dec 19, 2023

vercel bot temporarily deployed to Preview December 19, 2023 12:09 Inactive

github-actions bot added the merge conflict pull requests with merge conflict label Dec 20, 2023

nihal467 added changes required and removed needs testing labels Dec 20, 2023

rithviknishad mentioned this pull request Dec 21, 2023

Fix Loading State in Update Log List #6886

Closed

Pranshu1902 added 2 commits December 25, 2023 02:07

Merge branch 'develop' into issue#6770

c97c57f

complete merge

d1a4977

Pranshu1902 added needs testing and removed changes required merge conflict pull requests with merge conflict labels Dec 24, 2023

vercel bot temporarily deployed to Preview December 24, 2023 20:39 Inactive

remove empty card in loader

ada6efd

vercel bot temporarily deployed to Preview December 25, 2023 08:57 Inactive

nihal467 added tested and removed needs testing labels Dec 27, 2023

khavinshankar approved these changes Dec 28, 2023

View reviewed changes

khavinshankar merged commit 95353a4 into ohcnetwork:develop Dec 28, 2023
24 of 26 checks passed

rithviknishad mentioned this pull request Jan 30, 2024

Replace useDispatch in Patient Files (src/Components/Patient/) #7078

Merged

6 tasks

rithviknishad reviewed Jan 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timeline style view for Daily Rounds #6808

Timeline style view for Daily Rounds #6808

Pranshu1902 commented Dec 7, 2023 •

edited

Loading

vercel bot commented Dec 7, 2023 •

edited

Loading

netlify bot commented Dec 7, 2023 •

edited

Loading

Pranshu1902 commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023

rithviknishad commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023

rithviknishad commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023

nihal467 commented Dec 20, 2023

Pranshu1902 commented Dec 24, 2023 •

edited

Loading

nihal467 commented Dec 27, 2023

Pranshu1902 commented Dec 27, 2023

github-actions bot commented Dec 28, 2023

rithviknishad Jan 30, 2024

Timeline style view for Daily Rounds #6808

Timeline style view for Daily Rounds #6808

Conversation

Pranshu1902 commented Dec 7, 2023 • edited Loading

WHAT

🤖[deprecated] Generated by Copilot at f0ee615

Proposed Changes

Merge Checklist

HOW

🤖[deprecated] Generated by Copilot at f0ee615

vercel bot commented Dec 7, 2023 • edited Loading

netlify bot commented Dec 7, 2023 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

Pranshu1902 commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023

rithviknishad commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023

rithviknishad commented Dec 7, 2023

Pranshu1902 commented Dec 7, 2023 • edited Loading

github-actions bot commented Dec 20, 2023

nihal467 commented Dec 20, 2023

Pranshu1902 commented Dec 24, 2023 • edited Loading

nihal467 commented Dec 27, 2023

Pranshu1902 commented Dec 27, 2023

github-actions bot commented Dec 28, 2023

rithviknishad Jan 30, 2024

Choose a reason for hiding this comment

Pranshu1902 commented Dec 7, 2023 •

edited

Loading

`🤖[deprecated] Generated by Copilot at f0ee615`

`🤖[deprecated] Generated by Copilot at f0ee615`

vercel bot commented Dec 7, 2023 •

edited

Loading

netlify bot commented Dec 7, 2023 •

edited

Loading

Pranshu1902 commented Dec 7, 2023 •

edited

Loading

Pranshu1902 commented Dec 24, 2023 •

edited

Loading