Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Loading State in Update Log List #6886

Closed
gigincg opened this issue Dec 20, 2023 · 5 comments
Closed

Fix Loading State in Update Log List #6886

gigincg opened this issue Dec 20, 2023 · 5 comments
Assignees

Comments

@gigincg
Copy link
Member

gigincg commented Dec 20, 2023

In the Update Log List, in the Patient Dashboard, when you apply a filter, the skeletal loading component is currently being shown on top of the list of updates.

When Loading, the List of items should be shown & ensure that API failures or timeouts are handled as well.

@AshrafMd-1
Copy link
Contributor

I want to work on this issue can you assign me this issue ?

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 20, 2023

@AshrafMd-1 on a quick glance, the loading component is being shown separately that causes it to appear separately on top of the items. So remove the WhenLoading part and use
shimmer with <LoadingLogUpdateCard /> along with shimmerCount in the <PaginatedList.Items component itself, or if you want to show the list of items then just omit the loading state altogether.

@rithviknishad
Copy link
Member

Fix present in #6808 (comment)

@AshrafMd-1
Copy link
Contributor

@rithviknishad then should i unassign myself as the fix is already present

@Pranshu1902
Copy link
Contributor

Closed as completed in #6808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants