Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Results upload functionality is malfunctioning #6650

Closed
2 tasks
nihal467 opened this issue Nov 16, 2023 · 10 comments · Fixed by ohcnetwork/care#1747
Closed
2 tasks

External Results upload functionality is malfunctioning #6650

nihal467 opened this issue Nov 16, 2023 · 10 comments · Fixed by ohcnetwork/care#1747
Assignees
Labels

Comments

@nihal467
Copy link
Member

nihal467 commented Nov 16, 2023

Describe the bug

I've created a working external result import file with data from the Ernakulam district. When logged into Care with a user privilege other than "Ernakulam District," such as "Palakkad District," trying to upload the external result will succeed, but no data will be reflected in the external result tab

To Reproduce
Steps to reproduce the behavior:

  1. Login as a user other than Ernakulam district
  2. Click on import button and upload the file attached to this issue
  3. file upload will get uploaded and data won't be reflected
  4. See error

Expected behavior

  • relevant errors should be thrown incase the data is not successfully created in the frontend
  • check the latest comment as well

Screenshots

externalresultsample.csv

image

@konavivekramakrishna
Copy link
Contributor

@nihal467

I think everything is working fine, just need to change the sample format
image
image

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 18, 2023

@nihal467 @rithviknishad

can you please provide the login details for the user

@nihal467
Copy link
Member Author

@konavivekramakrishna use the login :
username ;nihal-district / Password : Test@123

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 18, 2023

@nihal467

I think this is a backend issue because the response is empty if the response includes any error message we can show the error message
image
image

@rithviknishad
Copy link
Member

@konavivekramakrishna The API has responded with 202 Accepted. Hence no errors were encountered. Have you tried calling the list API for the same after a successful upsert?

@konavivekramakrishna
Copy link
Contributor

@rithviknishad
yes
image

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 18, 2023

@rithviknishad

I will check once again if there is any error with api call

@konavivekramakrishna
Copy link
Contributor

konavivekramakrishna commented Nov 18, 2023

@rithviknishad

There is no error with api call

@rithviknishad
Copy link
Member

Currently, the user is able to upload results for other districts. However, the list view will only show results the user can access.

So if a user from Ernakulam uploads results with the local body that belongs to Kannur, then they won't be able to preview these bulk created results in the list view as the user does not have the permission.

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Nov 22, 2023
@nihal467
Copy link
Member Author

nihal467 commented Nov 27, 2023

  • The users should only be allowed to upload results for their particular district.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants