Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if user uploading External results is from same district #1747

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

Before importing the External results from the CSV file, check whether each of those results belong to the same district as that of the uploading user

Associated Issue

Fixes #6650

Screenshot from 2023-12-05 15-40-13

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8c633e2) 60.76% compared to head (ec7bbad) 60.74%.
Report is 5 commits behind head on master.

Files Patch % Lines
...are/facility/api/viewsets/patient_external_test.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage   60.76%   60.74%   -0.03%     
==========================================
  Files         210      210              
  Lines       11530    11536       +6     
  Branches     1642     1646       +4     
==========================================
+ Hits         7006     7007       +1     
- Misses       4283     4288       +5     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Aakash Singh <[email protected]>
@Pranshu1902 Pranshu1902 requested a review from sainak December 6, 2023 11:44
@vigneshhari vigneshhari merged commit 5563b48 into ohcnetwork:master Dec 7, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Results upload functionality is malfunctioning
5 participants