Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track camera feed views and display offline status #6408

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 6, 2023

WHAT

🤖 Generated by Copilot at c1fc396

This pull request enhances the video stream feature in the Feed component and adds error handling for the WebSocket connection in the useMSEMediaPlayer hook. It improves the user experience, the analytics, and the reliability of the video stream.

Display offline status for broken feed
image

Capture the camera feed view stats for analytics.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at c1fc396

  • Add error handler for WebSocket connection in useMSEMediaPlayer hook (link)
  • Import and use Spinner component to show loading animation in Feed component (link, link)
  • Add statusReported state to track and prevent duplicate reporting of stream status to analytics service in Feed component (link, link)
  • Modify stream initialization and status update logic in Feed component to avoid loading flicker, report status with additional parameters, and handle reconnection attempts (link)

@Ashesh3 Ashesh3 requested review from mathew-alex and a team October 6, 2023 07:30
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 6, 2023 07:30
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 7:43am

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0360acf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65225d5894dfc300084614af
😎 Deploy Preview https://deploy-preview-6408--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 6, 2023

Passing run #1379 ↗︎

0 78 0 0 Flakiness 0

Details:

Track camera feed views and display offline status
Project: CARE Commit: 0360acfb67
Status: Passed Duration: 03:17 💡
Started: Oct 8, 2023 7:46 AM Ended: Oct 8, 2023 7:50 AM

Review all test suite changes for PR #6408 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2b80bac into develop Oct 11, 2023
29 checks passed
@khavinshankar khavinshankar deleted the camera-feed-offline-status branch October 11, 2023 03:04
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants