You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request adds a new feature to manage assets by their warranty or AMC end of validity. It allows users to filter assets by date range, see the status of the warranty or AMC in a chip component, and export the filtered data. It modifies the files AssetFilter.tsx, AssetManage.tsx, and AssetsList.tsx to implement this feature.
Import modules and components for date range form field, date library, type definition, and utility function in AssetFilter.tsx (link)
Define a helper function to convert a value to a valid date object in AssetFilter.tsx (link)
Add a state variable to store the before and after values of the date range filter in AssetFilter.tsx (link)
Add the state values to the query parameters for fetching the filtered assets from the API in AssetFilter.tsx (link)
Define a handler function to update the state when the date range form field changes in AssetFilter.tsx (link)
Render a date range form field component with the name, label, value, onChange, and errorClassName props in AssetFilter.tsx (link)
Import a function to render a chip component based on the warranty or AMC end of validity value in AssetManage.tsx (link)
Render the chip component using the imported function and the asset's warranty or AMC end of validity value in AssetManage.tsx (link)
Add the warranty or AMC end of validity before and after values to the query parameters object for fetching the assets from the API in AssetsList.tsx (link)
Add the warranty or AMC end of validity before and after values to the dependency array of the useEffect hook for fetching the assets from the API in AssetsList.tsx (link)
Render the chip component using the same function and the asset's warranty or AMC end of validity value in the table row of each asset in AssetsList.tsx (link)
Add the warranty or AMC end of validity before and after values to the CSV export data for the filtered assets in AssetsList.tsx (link)
Define and export a function to render a chip component based on the warranty or AMC end of validity value in AssetsList.tsx (link)
the above asset has a warranty (31/01/2024) and today's date is (03/10/2023), as per the issue, the label should be coming from 3 months, but the above asset has more than 3 months exactly saying and the expiring label is shown to this asset
Note: if i make the warranty to any date in February, the warning is disappeared.
Was it intentional behavior, and discussed in the EOD call?
it is less than 3 months, and the alert is not working properly, make sure you cover all the edge cases, and mark it or testing
@nihal467 the no. of days between today and 8th of january is 91 days, I'm considering 90 days to be 3 months. So that is the reason why it doesn't show the label
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at e18d241
The pull request adds a new feature to manage assets by their warranty or AMC end of validity. It allows users to filter assets by date range, see the status of the warranty or AMC in a chip component, and export the filtered data. It modifies the files
AssetFilter.tsx,AssetManage.tsx, andAssetsList.tsxto implement this feature.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at e18d241
AssetFilter.tsx(link)AssetFilter.tsx(link)AssetFilter.tsx(link)AssetFilter.tsx(link)AssetFilter.tsx(link)AssetFilter.tsx(link)AssetManage.tsx(link)AssetManage.tsx(link)AssetsList.tsx(link)AssetsList.tsx(link)AssetsList.tsx(link)AssetsList.tsx(link)AssetsList.tsx(link)