Turn off no-undef as TypeScript handles it, lint --fix

ohcnetwork · Dec 16, 2024 · ffa6d1a · ffa6d1a
1 parent eb5728a
commit ffa6d1a
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 14 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -32,6 +32,7 @@ export default [
       globals: {
         ...globals.browser,
         ...globals.node,
+        React: true,
       },
       parserOptions: {
         ecmaFeatures: {
@@ -72,6 +73,7 @@ export default [
         },
       ],
       "@typescript-eslint/no-explicit-any": "warn",
+      "no-undef": "off",
     },
   },
 

diff --git a/src/CAREUI/interactive/SlideOver.tsx b/src/CAREUI/interactive/SlideOver.tsx
@@ -68,7 +68,6 @@ export default function SlideOver({
       <Dialog
         as="div"
         className="relative z-30"
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
         onClose={closeOnBackdropClick ? setOpen : () => {}}
       >
         <TransitionChild
@@ -117,7 +116,7 @@ export default function SlideOver({
                     className="flex h-8 w-8 items-center justify-center rounded-lg text-2xl hover:bg-black/20"
                     onClick={() => {
                       setOpen(false);
-                      onCloseClick && onCloseClick();
+                      onCloseClick?.();
                     }}
                   >
                     <CareIcon icon="l-arrow-left" />

diff --git a/src/Locale/update_locale.js b/src/Locale/update_locale.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-undef */
 import {
   existsSync,
   mkdirSync,
@@ -61,7 +60,7 @@ function getAllJSONFiles(folderName) {
   dir.forEach((file) => {
     try {
       files[file] = JSON.parse(readFile(`./${folderName}/${file}`));
-    } catch (e) {
+    } catch {
       throw new Error(`Cannot parse ${file} file!`);
     }
   });

diff --git a/src/PluginEngine.tsx b/src/PluginEngine.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable i18next/no-literal-string */
 import React, { Suspense } from "react";
 
 import ErrorBoundary from "@/components/Common/ErrorBoundary";

diff --git a/src/Providers/HistoryAPIProvider.tsx b/src/Providers/HistoryAPIProvider.tsx
@@ -2,7 +2,7 @@ import { useLocationChange } from "raviger";
 import { ReactNode, createContext, useState } from "react";
 
 export const HistoryContext = createContext<string[]>([]);
-// eslint-disable-next-line @typescript-eslint/no-empty-function
+
 export const ResetHistoryContext = createContext(() => {});
 
 export default function HistoryAPIProvider(props: { children: ReactNode }) {

diff --git a/src/components/Common/ExcelFIleDragAndDrop.tsx b/src/components/Common/ExcelFIleDragAndDrop.tsx
@@ -47,7 +47,7 @@ export default function ExcelFileDragAndDrop({
   const closeModal = () => {
     setSelectedFile(undefined);
     setFileData([]);
-    onClose && onClose();
+    onClose?.();
   };
 
   const onSelectFile = (file: Blob) => {
@@ -98,7 +98,7 @@ export default function ExcelFileDragAndDrop({
       setParsedData(parsedData);
       setValidData(ParsedDataWithOutErrors);
       if (ParsedDataWithOutErrors.length !== 0) {
-        setIsValid && setIsValid(true);
+        setIsValid?.(true);
       }
     }
   }, [fileData]);
@@ -199,7 +199,7 @@ export default function ExcelFileDragAndDrop({
                 setFileData([]);
                 setErrors([]);
                 setValidData([]);
-                setIsValid && setIsValid(false);
+                setIsValid?.(false);
                 dragProps.setDragOver(false);
                 dragProps.setFileDropError("");
               }}
@@ -229,6 +229,7 @@ export default function ExcelFileDragAndDrop({
             target="_blank"
             download
             onClick={(e) => e.stopPropagation()}
+            rel="noreferrer"
           >
             <CareIcon
               icon="l-download-alt"

diff --git a/src/components/Common/Sidebar/Sidebar.tsx b/src/components/Common/Sidebar/Sidebar.tsx
@@ -206,7 +206,7 @@ export const SidebarShrinkContext = createContext<{
   setShrinked: (state: boolean) => void;
 }>({
   shrinked: false,
-  // eslint-disable-next-line @typescript-eslint/no-empty-function
+
   setShrinked: () => {},
 });
 

diff --git a/src/components/Resource/ResourceBoard.tsx b/src/components/Resource/ResourceBoard.tsx
@@ -41,7 +41,7 @@ export default function BoardView() {
     cacheBlacklist: ["title"],
   });
   const [boardFilter, setBoardFilter] = useState(ACTIVE);
-  // eslint-disable-next-line
+
   const appliedFilters = formatFilter(qParams);
   const { t } = useTranslation();
 

diff --git a/src/service-worker.ts b/src/service-worker.ts
@@ -1,6 +1,4 @@
 /// <reference lib="webworker" />
-
-/* eslint-disable no-restricted-globals */
 // This service worker can be customized!
 // See https://developers.google.com/web/tools/workbox/modules
 // for the list of available Workbox modules, or add any other
@@ -13,7 +11,6 @@ import { precacheAndRoute } from "workbox-precaching";
 
 declare const self: ServiceWorkerGlobalScope;
 
-// eslint-disable-next-line no-restricted-globals
 const _ignored = self.__WB_MANIFEST.map((_) => {
   return _;
 });