Fixed fileupload name bug

ohcnetwork · Sep 26, 2024 · 4ba63ed · 4ba63ed
1 parent f5152fc
commit 4ba63ed
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/src/Components/Files/FileUpload.tsx b/src/Components/Files/FileUpload.tsx
@@ -271,7 +271,7 @@ export const FileUpload = (props: FileUploadProps) => {
                       label={t("enter_file_name")}
                       id="upload-file-name"
                       required
-                      value={fileUpload.fileNames[0]}
+                      value={fileUpload.fileNames[0] || ""}
                       disabled={!!fileUpload.progress}
                       onChange={(e) => fileUpload.setFileName(e.value)}
                       error={fileUpload.error || undefined}

diff --git a/src/Components/Patient/PatientConsentRecords.tsx b/src/Components/Patient/PatientConsentRecords.tsx
@@ -181,7 +181,7 @@ export default function PatientConsentRecords(props: {
           <TextFormField
             name="filename"
             label="File Name"
-            value={fileUpload.fileNames[0]}
+            value={fileUpload.fileNames[0] || ""}
             onChange={(e) => fileUpload.setFileName(e.value)}
           />
           <div className="flex gap-2">

diff --git a/src/Locale/en/FileUpload.json b/src/Locale/en/FileUpload.json
@@ -21,6 +21,7 @@
   "file_list_headings__supporting_info": "Supporting Info",
   "file_error__choose_file": "Please choose a file to upload",
   "file_error__file_name": "Please give a name for all files!",
+  "file_error__single_file_name": "Please give a name for the file",
   "change_file": "Change File",
   "file_error__file_size": "Maximum size of files is 100 MB",
   "file_error__file_type": "Invalid file type \".{{extension}}\" Allowed types: {{allowedExtensions}}",

diff --git a/src/Utils/useFileUpload.tsx b/src/Utils/useFileUpload.tsx
@@ -2,6 +2,7 @@ import {
   ChangeEvent,
   DetailedHTMLProps,
   InputHTMLAttributes,
+  useEffect,
   useState,
 } from "react";
 import {
@@ -104,6 +105,11 @@ export default function useFileUpload(
     });
   };
 
+  useEffect(() => {
+    const blanks = Array(files.length).fill("");
+    setUploadFileNames((names) => [...names, ...blanks].slice(0, files.length));
+  }, [files]);
+
   const validateFileUpload = () => {
     if (files.length === 0) {
       setError(t("file_error__choose_file"));
@@ -198,10 +204,11 @@ export default function useFileUpload(
     setProgress(0);
 
     for (const [index, file] of files.entries()) {
-      const filename =
-        uploadFileNames[index] === "" && file
-          ? file.name
-          : uploadFileNames[index];
+      const filename = uploadFileNames[index];
+      if (!filename) {
+        setError(t("file_error__single_file_name"));
+        return;
+      }
 
       const { data } = await request(routes.createUpload, {
         body: {