Lint CI: Show errors only and fix existing lint errors (#6494)

* annotate errors only

* fix existing errors

.github/workflows/linter.yml

@@ -16,16 +16,16 @@ jobs:
       statuses: write
 
     steps:
-    - name: Checkout code
-      uses: actions/checkout@v2
+      - name: Checkout code
+        uses: actions/checkout@v2
 
-    - name: Set up Node.js
-      uses: actions/setup-node@v2
-      with:
-        node-version: '18'
+      - name: Set up Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: "18"
 
-    - name: Install dependencies
-      run: npm ci
+      - name: Install dependencies
+        run: npm ci
 
-    - name: Run lint
-      run: npm run lint
+      - name: Run lint
+        run: npm run lint --quiet

src/CAREUI/interactive/FiltersSlideover.tsx

@@ -3,11 +3,12 @@ import useFilters from "../../Common/hooks/useFilters";
 import ButtonV2 from "../../Components/Common/components/ButtonV2";
 import CareIcon from "../icons/CareIcon";
 import SlideOver from "./SlideOver";
+import { ReactNode } from "react";
 
 type AdvancedFilter = ReturnType<typeof useFilters>["advancedFilter"];
 
 interface Props {
-  children: any;
+  children: ReactNode | ReactNode[];
   advancedFilter: AdvancedFilter;
   onClear?: () => void;
   onApply?: () => void;

src/Components/Assets/AssetImportModal.tsx

@@ -33,24 +33,19 @@ const AssetImportModal = ({ open, onClose, facility }: Props) => {
   const [errors, setErrors] = useState<any>({
     location: "",
   });
-  const [locations, setLocations] = useState<any>([]);
   const { sample_format_asset_import } = useConfig();
-  const [locationsLoading, setLocationsLoading] = useState(false);
 
   const closeModal = () => {
     setPreview(undefined);
     setSelectedFile(undefined);
     onClose && onClose();
   };
-  useQuery(routes.listFacilityAssetLocation, {
+  const { data, loading } = useQuery(routes.listFacilityAssetLocation, {
     pathParams: { facility_external_id: `${facility.id}` },
-    onResponse: ({ res, data }) => {
-      if (res?.status === 200 && data) {
-        setLocations(data.results);
-      }
-    },
   });
 
+  const locations = data?.results || [];
+
   useEffect(() => {
     const readFile = async () => {
       try {
@@ -209,7 +204,7 @@ const AssetImportModal = ({ open, onClose, facility }: Props) => {
       fixedWidth={false}
     >
       <span className="mt-1 text-gray-700">{facility.name}</span>
-      {!locationsLoading && locations.length === 0 ? (
+      {!loading && locations.length === 0 ? (
         <>
           <div className="flex h-full flex-col items-center justify-center">
             <h1 className="m-7 text-2xl font-medium text-gray-700">

src/Components/Assets/AssetType/ONVIFCamera.tsx

@@ -18,7 +18,6 @@ import useQuery from "../../../Utils/request/useQuery";
 
 import CareIcon from "../../../CAREUI/icons/CareIcon";
 
-
 interface Props {
   assetId: string;
   facilityId: string;
@@ -135,7 +134,7 @@ const ONVIFCamera = ({ assetId, facilityId, asset, onUpdated }: Props) => {
     }
     setLoadingAddPreset(false);
   };
-  
+
   if (isLoading || loading || !facility) return <Loading />;
 
   const fallbackMiddleware =