-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added filter for is_archieved on file viewset #2704
added filter for is_archieved on file viewset #2704
Conversation
📝 WalkthroughWalkthroughThe pull request introduces filtering capabilities for file uploads in the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
care/emr/api/viewsets/file_upload.py (1)
54-56
: Consider adding usage documentation or docstring for the filter class.It might be slightly unexpected for new contributors or maintainers if there's no brief explanation of how
FileUploadFilter
should be used withis_archived
. You might want to provide a small docstring indicating its filtering mechanism. This helps ensure clarity, especially when adding more filters later.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
care/emr/api/viewsets/file_upload.py
(3 hunks)
🔇 Additional comments (1)
care/emr/api/viewsets/file_upload.py (1)
66-67
: Verify test coverage for newly introduced filtering.Even though it looks straightforward, it’s worth confirming that test cases exist for the
FileUploadFilter
usage. This will verify that theis_archived
field filtering works as intended and integrates seamlessly with the viewset.
Proposed Changes
Associated Issue
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins
Summary by CodeRabbit