Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added care livekit plugin #2505

Closed
wants to merge 1 commit into from
Closed

Added care livekit plugin #2505

wants to merge 1 commit into from

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar requested a review from a team as a code owner September 29, 2024 11:56
@vigneshhari
Copy link
Member

The requirements should not be added here, it should be maintained in the source repo in its own requirements.
Is this really needed for all our deployments?

@gigincg
Copy link
Member

gigincg commented Sep 30, 2024

@vigneshhari This is not required to be enabled by default,

@vigneshhari We can keep the requirements for livekit in the plugin itself right?

@vigneshhari
Copy link
Member

@gigincg Yes plugin requirements should not be maintained in the core app. You can remove the plug config as well if its not required by default. We can close this MR because no changes are required for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants