Prevent destination facility from marking shift as complete #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashesh3
requested review from
vigneshhari,
rithviknishad,
khavinshankar and
sainak
sainak
reviewed
Apr 24, 2024
Co-authored-by: Aakash Singh <[email protected]>
sainak
reviewed
Apr 29, 2024
sainak
approved these changes
Apr 29, 2024
vigneshhari
requested changes
May 2, 2024
| destination_facility = ( | ||
| validated_data.get("assigned_facility") or instance.assigned_facility | ||
| ) | ||
| if destination_facility and destination_facility.users.contains(user): |
There was a problem hiding this comment.
if a user is part of the destination and receiving facility this might become a problem.
sainak
approved these changes
Jun 3, 2024
rithviknishad
approved these changes
Jun 3, 2024
|
the related frontend PR is having bug, don't merge it |
|
LGTM @vigneshhari you can review it, the PR is working |
vigneshhari
requested changes
Jun 13, 2024
vigneshhari
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: ohcnetwork/care_fe#7684
Frontend change: ohcnetwork/care_fe#7697
Adds a permission check to disallow destination facility staff from marking the shifting request as complete, while still allowing state and district admin to do the same. Also auto discharge is removed for completed stage, and the UI handles the discharge + shifting change together.