Soft delete assets from deleted facilities/hospitals

[hrit2773]

Fixes #1982 issue, enabled soft delete of assets by overriding delete method in facility model

[rithviknishad]

No changes to the fields in the model were made. But why are there migrations for it?

[hrit2773]

@rithviknishad I was initially using models.cascade but later I realised I need to perform soft delete so I changed it back to original ones so that's why you can see those redundant migrations.But the functionality is working. Should I remove those redundant migrations?

[hrit2773]

@rithviknishad I made a second commit i removed those redundant migration history so effectively i just added the delete method in facility model

[rithviknishad]

Custom migration needed to delete existing such assets of deleted facility.

https://docs.djangoproject.com/en/5.0/ref/migration-operations/#runpython

[rithviknishad]

Also test cases needs to be added. It'd be great if you could follow the PR template 😄

[hrit2773]

@rithviknishad ya sure I'll make the changes by today

[hrit2773]

@rithviknishad I added custom migrations and also added api test case but the tests are not running in my machine because im using windows and im probably getting some connection errors with the test db like some dbus connection errors and no such bucket found. It is giving a failed test for medibase api maybe some db connection issues in windows

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (12afd7a) to head (5850871).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1996      +/-   ##
===========================================
+ Coverage    65.38%   65.41%   +0.02%     
===========================================
  Files          242      242              
  Lines        13976    13988      +12     
  Branches      1937     1938       +1     
===========================================
+ Hits          9138     9150      +12     
  Misses        4455     4455              
  Partials       383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hrit2773]

@sainak plz review the commit...

[hrit2773]

@sainak @rithviknishad i added the cron job and should i remove the tests also for soft delete that i created because now that wont work right and maybe the custom migration is also not needed because every midnight the assets will be soft deleted and should i add logging infos and warnings in the task function? plz review it and tell me if any changes required

[rithviknishad]

@hrit2773 You can remove the custom migration since it'd be taken care by the celery task itself right.

[hrit2773]

@hrit2773 You can remove the custom migration since it'd be taken care by the celery task itself right.

@rithviknishad yes I'll remove it and I'll remove the api test case also because I feel that is not needed

[hrit2773]

@sainak view the changes.. and also replaced external_id with id

[hrit2773]

@sainak can you review the changes

[hrit2773]

@rithviknishad @sainak lets close this issue today

[hrit2773]

@sainak @vigneshhari can you review this PR

[vigneshhari]

Why is this a background job? cant we just soft delete assets if the facility is archived? we cant add assets to a deleted facility right? @sainak

[hrit2773]

Why is this a background job? cant we just soft delete assets if the facility is archived? we cant add assets to a deleted facility right? @sainak

@vigneshhari I did that initially but @sainak asked me to run an cron job