Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes something went wrong error for duplicate patient no. check for OP consultations and imrpove error message #1974

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 15, 2024

Proposed Changes

  • Raise validation error for duplicate patient no. check also for OP consultations (so far caused 500 as it was a DB constraint
  • Improve error message

Associated Issue

image

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad requested review from sainak and Ashesh3 March 15, 2024 05:24
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base (8616f5c) to head (51ce81e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1974   +/-   ##
========================================
  Coverage    62.19%   62.20%           
========================================
  Files          221      221           
  Lines        12203    12204    +1     
  Branches      1742     1742           
========================================
+ Hits          7590     7591    +1     
  Misses        4305     4305           
  Partials       308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rithviknishad rithviknishad marked this pull request as draft March 15, 2024 08:26
@rithviknishad rithviknishad marked this pull request as ready for review March 15, 2024 08:58
@rithviknishad rithviknishad requested a review from sainak March 15, 2024 08:58
@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 3db7a9e into develop Mar 15, 2024
7 checks passed
@gigincg gigincg deleted the fix-patient-no-error-msg branch March 15, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the Error in Consultation form to be self explanatory
5 participants