[BUG] fix Location/ Bed Management issue ( District Lab Admin Account)

[AnkurPrabhu]

Proposed Changes

• Brief of changes made.
  the issue here was mainly permission related
  District Lab Admin had read access for facility but not object read access (refer FacilityPermissionMixin)
  same for asset_location while actually managing beds it uses (refer FacilityRelatedPermissionMixin)

Associated Issue

• Link to issue here : issue

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[AnkurPrabhu]

@rithviknishad @sainak pls take a look works fine for me

[rithviknishad]

A state lab admin and greater user would have access to facilities belonging to the user's state and not user's district

[rithviknishad]

Also, need tests

[AnkurPrabhu]

A state lab admin and greater user would have access to facilities belonging to the user's state and not user's district

@rithviknishad i did not understand this comment what change is needed we dont allow object read for district lab admin ?

i added it to district lab admin as in FacilityQSPermissions we allow DistrictLabAdmin to view it

[rithviknishad]

FacilityQSPermissions also has a case for state lab admin and greater user:

[AnkurPrabhu]

okay is this what ur saying
i have to add
or (
hasattr(self, "district")
and request.user.user_type >= User.TYPE_VALUE_MAP["DistrictLabAdmin"]
and request.user.district == self.district
)

instead of simply -> adding request.user.user_type >= User.TYPE_VALUE_MAP["DistrictLabAdmin"] ?

also same changes for statelabadmin as well

[AnkurPrabhu]

hey i just noticed that for model AssetLocation we dont have a field named state thats why its failing for assetlocation where as for facility we have state so this fixed the facility permission issue part but shows the error while managing beds
should i add the state field ?
@rithviknishad

[rithviknishad]

We don't need to add a state field as it'd no longer be having a single source of truth.

A facility belongs to a state and Asset Location belongs to a facility. Bed belongs to an Asset Location.

[AnkurPrabhu]

@rithviknishad i have added tests and also did the same for state lab admin looks good to me let me know if any changes are required

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.35%. Comparing base (90565c2) to head (d23bf78).
Report is 21 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1959      +/-   ##
===========================================
+ Coverage    62.19%   62.35%   +0.15%     
===========================================
  Files          221      221              
  Lines        12203    12219      +16     
  Branches      1742     1744       +2     
===========================================
+ Hits          7590     7619      +29     
+ Misses        4305     4289      -16     
- Partials       308      311       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AnkurPrabhu]

@khavinshankar pls take a look