Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate consultation's assigned_to to assigned_clinicians #1903

Closed
wants to merge 11 commits into from

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 21, 2024

Requires: #1900
This pull request migrates the assigned_to field in the consultation model to assigned_clinicians. This change is made to improve clarity and consistency in the codebase.

Phases for the change

  1. Schema Changes
  2. Migrating Data and Deprecating assigned_to

Related Issue: ohcnetwork/care_fe#6276

@Ashesh3 Ashesh3 changed the base branch from assigned_clinicians_schema to master February 21, 2024 13:48
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 36.00000% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 62.56%. Comparing base (51ce81e) to head (36a233e).
Report is 61 commits behind head on develop.

❗ Current head 36a233e differs from pull request most recent head f9fe512. Consider uploading reports for the commit f9fe512 to get more accurate results

Files Patch % Lines
care/utils/notification_handler.py 9.09% 8 Missing and 2 partials ⚠️
care/facility/api/serializers/file_upload.py 0.00% 6 Missing and 1 partial ⚠️
...e/facility/api/serializers/patient_consultation.py 57.14% 3 Missing and 3 partials ⚠️
care/users/api/viewsets/users.py 0.00% 3 Missing ⚠️
care/facility/api/serializers/daily_round.py 0.00% 1 Missing and 1 partial ⚠️
...are/facility/api/viewsets/patient_investigation.py 0.00% 2 Missing ⚠️
care/utils/queryset/patient.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1903      +/-   ##
===========================================
+ Coverage    62.20%   62.56%   +0.36%     
===========================================
  Files          221      223       +2     
  Lines        12204    12278      +74     
  Branches      1742     1749       +7     
===========================================
+ Hits          7591     7682      +91     
+ Misses        4305     4273      -32     
- Partials       308      323      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashesh3 Ashesh3 removed the blocked label Mar 19, 2024
@Ashesh3
Copy link
Member Author

Ashesh3 commented Mar 19, 2024

@sainak @rithviknishad @vigneshhari could you guys review this once?

care/users/api/viewsets/users.py Show resolved Hide resolved
care/utils/notification_handler.py Outdated Show resolved Hide resolved
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to note: m2m lookups can result in duplicates

…ransfer assigned_to values to ConsultationClinician model
@Ashesh3
Copy link
Member Author

Ashesh3 commented Mar 21, 2024

m2m lookups can result in duplicates

Hey, could you elaborate a bit more on this? Lookups can result in duplications? do you mean that a select query might return the same record twice in some cases? if so, which cases?

@Ashesh3 Ashesh3 requested a review from sainak March 31, 2024 13:56
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 24, 2024 10:06
@Ashesh3
Copy link
Member Author

Ashesh3 commented Apr 24, 2024

@rithviknishad @sainak @khavinshankar @vigneshhari could you guys review this?

@Ashesh3 Ashesh3 requested a review from rithviknishad April 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants