-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate consultation's assigned_to to assigned_clinicians #1903
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1903 +/- ##
===========================================
+ Coverage 62.20% 62.56% +0.36%
===========================================
Files 221 223 +2
Lines 12204 12278 +74
Branches 1742 1749 +7
===========================================
+ Hits 7591 7682 +91
+ Misses 4305 4273 -32
- Partials 308 323 +15 ☔ View full report in Codecov by Sentry. |
@sainak @rithviknishad @vigneshhari could you guys review this once? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing to note: m2m lookups can result in duplicates
…ransfer assigned_to values to ConsultationClinician model
Hey, could you elaborate a bit more on this? Lookups can result in duplications? do you mean that a select query might return the same record twice in some cases? if so, which cases? |
@rithviknishad @sainak @khavinshankar @vigneshhari could you guys review this? |
Requires: #1900
This pull request migrates the
assigned_to
field in theconsultation
model toassigned_clinicians
. This change is made to improve clarity and consistency in the codebase.Phases for the change
Related Issue: ohcnetwork/care_fe#6276