Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track occupation of patient #1869

Closed

Conversation

konavivekramakrishna
Copy link
Contributor

Proposed Changes

  • change occupation choices
  • change head_of_household can be null

Associated Issue

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@konavivekramakrishna
Copy link
Contributor Author

@rithviknishad

can you please review this? I am facing an issue: if a patient first selects an occupation, later, if the patient unselects it, the system should either delete the record or simply keep the occupation field as null

@rithviknishad
Copy link
Member

@sainak, how about we keep a char choices field occupation in the patient registration table to keep it simple instead?

@rithviknishad rithviknishad requested a review from sainak February 3, 2024 15:29
care/facility/models/patient.py Show resolved Hide resolved
care/facility/api/serializers/patient.py Outdated Show resolved Hide resolved
@sainak
Copy link
Member

sainak commented Feb 3, 2024

@sainak, how about we keep a char choices field occupation in the patient registration table to keep it simple instead?

meta table is a good to have, it helps in keeping the main table less cluttered

@konavivekramakrishna
Copy link
Contributor Author

@rithviknishad

can you please review the changes

@konavivekramakrishna konavivekramakrishna changed the title draft support for patient occupation Track occupation of patient Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fcea22e) 61.65% compared to head (57a2e66) 61.64%.

Files Patch % Lines
care/facility/api/serializers/patient.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   61.65%   61.64%   -0.02%     
==========================================
  Files         211      211              
  Lines       11721    11722       +1     
  Branches     1664     1665       +1     
==========================================
- Hits         7227     7226       -1     
- Misses       4196     4198       +2     
  Partials      298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak
Copy link
Member

sainak commented Feb 8, 2024

@konavivekramakrishna run precommit on the changed files

https://github.com/coronasafe/care/blob/master/CONTRIBUTING.md#getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants