Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for filtering patients by diagnoses #1830

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 17, 2024

Proposed Changes

  • Adds support for filtering patients by diagnoses of last consultation and verification status.
  • Adds support for retrieving ICD11 Diagnosis by ID

Associated Issue

GET /api/v1/patient/
image

image

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a5c790c) 61.62% compared to head (7ea5f04) 61.67%.

Files Patch % Lines
care/facility/api/viewsets/patient.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   61.62%   61.67%   +0.05%     
==========================================
  Files         212      212              
  Lines       11664    11685      +21     
  Branches     1655     1658       +3     
==========================================
+ Hits         7188     7207      +19     
- Misses       4180     4181       +1     
- Partials      296      297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rithviknishad rithviknishad marked this pull request as ready for review January 17, 2024 13:23
@rithviknishad rithviknishad requested a review from sainak January 18, 2024 06:07
@nihal467
Copy link
Member

LGTM

@vigneshhari vigneshhari merged commit 32043d0 into master Jan 25, 2024
11 checks passed
@vigneshhari vigneshhari deleted the search-patients-by-diagnoses branch January 25, 2024 04:44
@vigneshhari
Copy link
Member

Lets look at N+1 query issues in this approach as well, maybe as a seperate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants