ABDM: Log the errors instead of sending them as a response

care/abdm/api/viewsets/auth.py

@@ -1,4 +1,5 @@
 import json
+import logging
 from datetime import datetime, timedelta
 
 from django.core.cache import cache
@@ -14,6 +15,8 @@
 from care.facility.models.patient_consultation import PatientConsultation
 from config.authentication import ABDMAuthentication
 
+logger = logging.getLogger(__name__)
+
 
 class OnFetchView(GenericAPIView):
     permission_classes = (IsAuthenticated,)
@@ -25,7 +28,14 @@ def post(self, request, *args, **kwargs):
         try:
             AbdmGateway().init(data["resp"]["requestId"])
         except Exception as e:
-            return Response({"error": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+            logger.warning(
+                f"Error: OnFetchView::post failed while initialising ABDM Gateway, Reason: {e}",
+                exc_info=True,
+            )
+            return Response(
+                {"error": "Error: Initialising ABDM Gateway failed."},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
 
         return Response({}, status=status.HTTP_202_ACCEPTED)
 
@@ -346,10 +356,14 @@ def post(self, request, *args, **kwargs):
                 }
             )
         except Exception as e:
+            logger.warning(
+                f"Error: RequestDataView::post failed to notify (health-information/notify). Reason: {e}",
+                exc_info=True,
+            )
             return Response(
                 {
                     "detail": "Failed to notify (health-information/notify)",
-                    "error": str(e),
+                    "error": "Error: Failed to notify",
                 },
                 status=status.HTTP_400_BAD_REQUEST,
             )

care/abdm/api/viewsets/healthid.py

@@ -1,5 +1,6 @@
 # ABDM HealthID APIs
 
+import logging
 from datetime import datetime
 
 from drf_spectacular.utils import extend_schema
@@ -31,6 +32,8 @@
 from config.auth_views import CaptchaRequiredException
 from config.ratelimit import ratelimit
 
+logger = logging.getLogger(__name__)
+
 
 # API for Generating OTP for HealthID
 class ABDMHealthIDViewSet(GenericViewSet, CreateModelMixin):
@@ -363,8 +366,15 @@ def link_via_qr(self, request):
                     }
                 )
             except Exception as e:
+                logger.warning(
+                    f"Error: ABDMHealthIDViewSet::link_via_qr failed to fetch nodes. Reason: {e}",
+                    exc_info=True,
+                )
                 return Response(
-                    {"detail": "Failed to fetch modes", "error": str(e)},
+                    {
+                        "detail": "Failed to fetch modes",
+                        "error": "Error: ABDM Gateway node fetch failed",
+                    },
                     status=status.HTTP_400_BAD_REQUEST,
                 )
 
@@ -419,8 +429,16 @@ def get_new_linking_token(self, request):
                 }
             )
         except Exception as e:
+            logger.warning(
+                f"Error: ABDMHealthIDViewSet::get_new_linking_token failed to fetch nodes. Reason: {e}",
+                exc_info=True,
+            )
+
             return Response(
-                {"detail": "Failed to fetch modes", "error": str(e)},
+                {
+                    "detail": "Failed to fetch modes",
+                    "error": "Error: failed to fetch nodes.",
+                },
                 status=status.HTTP_400_BAD_REQUEST,
             )
 
@@ -463,8 +481,16 @@ def add_care_context(self, request, *args, **kwargs):
                 }
             )
         except Exception as e:
+            logger.warning(
+                f"Error: ABDMHealthIDViewSet::add_care_context failed. Reason: {e}",
+                exc_info=True,
+            )
+
             return Response(
-                {"detail": "Failed to add care context", "error": str(e)},
+                {
+                    "detail": "Failed to add care context",
+                    "error": "Error: Failed to integrate care.",
+                },
                 status=status.HTTP_400_BAD_REQUEST,
             )
 
@@ -496,8 +522,13 @@ def patient_sms_notify(self, request, *args, **kwargs):
                 }
             )
         except Exception as e:
+            logger.warning(
+                f"Error: ABDMHealthIDViewSet::patient_sms_notify failed to send SMS. Reason: {e}",
+                exc_info=True,
+            )
+
             return Response(
-                {"detail": "Failed to send SMS", "error": str(e)},
+                {"detail": "Failed to send SMS", "error": "Error: SMS not sent."},
                 status=status.HTTP_400_BAD_REQUEST,
             )
 

data/medibase.json

@@ -1144305,4 +1144305,4 @@
   "cims_class_link": "/india/drug/search?q=drugs+for+erectile+dysfunction&mtype=brand&code=10d",
   "cims_class": "Drugs for Erectile Dysfunction",
   "atc_classification": "G04BE03 - sildenafil ; Belongs to the class of drugs used in erectile dysfunction."
-}]
+}]