-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace littletable with redis-om(redisearch) #1788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
force-pushed
the
sainak/feat/redis-search
branch
from
December 27, 2023 19:31
685a075
to
f4159aa
Compare
sainak
changed the title
Use Redisearch for ICD11 and Medibase
Replace littletable with redis-om
Dec 27, 2023
sainak
force-pushed
the
sainak/feat/redis-search
branch
2 times, most recently
from
December 28, 2023 08:04
2be3bcd
to
e015c41
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 61.57% 61.64% +0.07%
==========================================
Files 208 212 +4
Lines 11556 11658 +102
Branches 1649 1650 +1
==========================================
+ Hits 7116 7187 +71
- Misses 4149 4180 +31
Partials 291 291 ☔ View full report in Codecov by Sentry. |
sainak
force-pushed
the
sainak/feat/redis-search
branch
from
December 28, 2023 10:09
e015c41
to
9741379
Compare
sainak
requested review from
Ashesh3,
gigincg,
vigneshhari,
rithviknishad and
khavinshankar
December 28, 2023 10:12
sainak
changed the title
Replace littletable with redis-om
Replace littletable with redis-om(redisearch)
Dec 28, 2023
sainak
force-pushed
the
sainak/feat/redis-search
branch
from
December 28, 2023 15:20
753e38f
to
d034053
Compare
its a p1 priority , for fixing facility cover image upload in local |
rithviknishad
approved these changes
Jan 8, 2024
Ashesh3
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request updates the code to use Redisearch for PMJYPackages, ICD11 and Medibase data. It includes changes to load the data into Redis and use Redisearch for querying.
https://redis.io/docs/interact/search-and-query/query/full-text/
https://github.com/redis/redis-om-python
Associated Issue
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins