Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

District Filter to display State's name along with the district's name #1735

Closed
wants to merge 5 commits into from

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

  • Added state name to DistrictSerializer's to_representation method

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak
Copy link
Member

sainak commented Dec 6, 2023

@nihal467 @GokulramGHV, can you check if this isnt affecting other district fields?

@GokulramGHV
Copy link
Member Author

GokulramGHV commented Dec 26, 2023

@sainak I've checked the frontend and I've not found any instance where district name is used directly instead of district id.
Afaik, i don't think it's affecting the other fields

@sainak
Copy link
Member

sainak commented Dec 27, 2023

@GokulramGHV can you check why the test is failing?

@vigneshhari
Copy link
Member

This might create a ton of N+1 queries if the query does not select the state as well.

@vigneshhari
Copy link
Member

This MR is going to be closed, if this feature is required, the state has to be serialized as a separate field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants