Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Display Issues for Oxygen Cylinder Capacity in Facility Exports #1732

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 29, 2023

Proposed Changes

In this pull request, we fix an issue related to the display of the "oxygen_capacity" along with "type_b_cylinders", "type_c_cylinders", and "type_d_cylinders" fields in the facility exports.

Previously, these fields were showing up in all four exports options (Facility, Capacity, Doctor, Triage). However, as per the expected behavior, these fields should only be displayed in the capacity export.

We have addressed this bug by reorganizing the position of these fields in the 'facility.py' model. They are now set to only appear in the "capacity export", thereby aligning their appearance with the expected behavior.

This fix ensures improved readability and accurate data display while exporting different facility data categories. We believe this change will contribute to the overall effectiveness and usability of the facility exports feature.

Associated Issue

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f287b46) 60.76% compared to head (c8aeb63) 60.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1732   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         210      210           
  Lines       11530    11530           
  Branches     1642     1642           
=======================================
  Hits         7006     7006           
  Misses       4283     4283           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 19d414f into master Dec 7, 2023
11 checks passed
@vigneshhari vigneshhari deleted the capacity-export branch December 7, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oxygen Capacity are shown across all Facility Export
4 participants