Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Location Filtering in Patient Consultations #1679

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 17, 2023

Related issue: ohcnetwork/care_fe#6426
Frontend Change: ohcnetwork/care_fe#6456

This pull request introduces a new filtering feature in the patient consultations section, enabling users to filter consultations based on location. The location filter utilizes the current_bed__location_external_id field to filter the patient consultations accordingly. Changes include modifications in the PatientConsultationFilter class in patient_consultation.py and the respective tests to ensure the functionality works as expected.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

image

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0daef7f) 60.02% compared to head (e65e4c6) 60.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1679   +/-   ##
=======================================
  Coverage   60.02%   60.02%           
=======================================
  Files         208      208           
  Lines       11319    11320    +1     
  Branches     1606     1606           
=======================================
+ Hits         6794     6795    +1     
  Misses       4301     4301           
  Partials      224      224           
Files Coverage Δ
care/facility/api/viewsets/patient.py 62.45% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

@Ashesh3 the filters are malfunctioning, check the linked front-end PR comment to see more details

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 23, 2023

@Ashesh3 the filters are malfunctioning, check the linked front-end PR comment to see more details

Issue fixed.

@nihal467
Copy link
Member

nihal467 commented Oct 25, 2023

LGTM @vigneshhari can you review it

@vigneshhari vigneshhari merged commit 92b99fd into master Oct 30, 2023
7 checks passed
@vigneshhari vigneshhari deleted the location-filter branch October 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants