-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patient Consultation: Route to Facility 🏥, Admission Date & Time 🕚, Rename variable: verified_by
to treating_physician
#1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Tests failing |
rithviknishad
requested review from
sainak,
Ashesh3,
vigneshhari and
khavinshankar
October 23, 2023 13:52
Functionality looks good to me, @vigneshhari can you review it |
Ashesh3
approved these changes
Oct 25, 2023
sainak
approved these changes
Oct 30, 2023
This PR is probably causing me to age a bit faster :/ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
+ Coverage 60.43% 60.53% +0.09%
==========================================
Files 210 210
Lines 11473 11505 +32
Branches 1630 1636 +6
==========================================
+ Hits 6934 6964 +30
Misses 4307 4307
- Partials 232 234 +2 ☔ View full report in Codecov by Sentry. |
sainak
approved these changes
Nov 14, 2023
care/facility/migrations/0395_alter_patientconsultation_route_to_facility.py
Outdated
Show resolved
Hide resolved
vigneshhari
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue
Proposed Changes
route_to_facility
based on deprecatedconsultation_status
field value.Renamed Fields
consultation_status
route_to_facility
verified_by
treating_physician
New Fields
transferred_from_location
AssetLocation
INTRA_FACILITY_TRANSFER
referred_from_facility
Facility
INTER_FACILITY_TRANSFER
; **XOR required withreferred_from_facility_external
referred_from_facility_external
INTER_FACILITY_TRANSFER
; **XOR required withreferred_from_facility
referred_by_external
INTER_FACILITY_TRANSFER
icu_admission_date
OUTPATIENT/ER
Migrations
Admission Date reset to 00:00 of timezone - Before Migration
Admission Date reset to 00:00 of timezone - After Migration
Populate Route to Facility - Before Migration
Populate Route to Facility - After Migration
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins