-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ICD11 Table; Cleanup in-memory search #1636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
+ Coverage 59.11% 59.46% +0.34%
==========================================
Files 207 208 +1
Lines 11264 11283 +19
Branches 1599 1597 -2
==========================================
+ Hits 6659 6709 +50
+ Misses 4405 4372 -33
- Partials 200 202 +2
☔ View full report in Codecov by Sentry. |
rithviknishad
force-pushed
the
refactor-icd11-table
branch
from
September 25, 2023 15:22
0d3dee8
to
2f3f4da
Compare
sainak
reviewed
Sep 25, 2023
Co-authored-by: Aakash Singh <[email protected]>
sainak
approved these changes
Sep 25, 2023
Ashesh3
approved these changes
Sep 26, 2023
marking as hold for ohcnetwork/care_fe#5293 Edit: planned to be done as a follow-up PR as more understanding is required about how ICD11 is structured. |
LGTM, Tested in local |
vigneshhari
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
.../<possible_duplicate_id>/mms/...
) is now mapped in the following manner:MetaICD11Diagnosis
table can be deleted once metabase queries are updated to the new table.id
andlabel
are loaded onto the in-memory table.Associated Issue
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins