-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Nurse user type and promote existing staffs to nurse #1589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
You should rename the existing
Staff
type toNurse
type(10, "Nurse")
and then create a new role forStaff
. Effective order should be:7: StaffReadOnly; 8: Staff; 9: NurseReadOnly; 10: Nurse
-
The permissions for
Nurse
andStaff
should be the same for now. However, in a later PR we can downgrade the permissions ofStaff
to have access only to Admin / Facility data and not Patient Data.
574db3f
to
8438a22
Compare
tested locally looks good to me |
@cp-coder the tests are failing |
@cp-coder clear the merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For everywhere that authzn checks are done at serializer validate: Why are Authz checks done in the serializer validate? Shouldn't this be done by DRY Permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests and lint checks are failing. also one of the earlier review is still not resolved
aa1eade
to
404b811
Compare
The PR is good for testing |
closing in favor of #1819 |
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins