Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor consultation bed create and shift logic #1577

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 5, 2023

Proposed Changes

  • refactor and fix the conditions to check bed overlaps
  • add more tests

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35% 🎉

Comparison is base (b5e482c) 58.72% compared to head (1159f83) 59.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   58.72%   59.08%   +0.35%     
==========================================
  Files         205      205              
  Lines       11136    11144       +8     
  Branches     1583     1587       +4     
==========================================
+ Hits         6540     6584      +44     
+ Misses       4387     4360      -27     
+ Partials      209      200       -9     
Files Changed Coverage Δ
care/facility/api/serializers/bed.py 84.27% <100.00%> (+17.38%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 99f959b into master Sep 13, 2023
8 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/beds branch September 13, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beds can have conflicting records across patients
5 participants