Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign Key to User for Consultation Verified By #1567

Merged
merged 12 commits into from
Sep 7, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 31, 2023

Proposed Changes

  • Renamed field: verified_by to deprecated_verified_by TextField in Consultation
  • Add field: verified_by ForeignKey to User model in Consultation
  • Add serializer validation to validate verified_by user is of Doctor role and is a home facility user of the consultation's facility.
  • Add search for FacilityUserViewset
  • Updated Discharge Summary Template to reflect the changes

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@nihal467
Copy link
Member

nihal467 commented Sep 1, 2023

LGTM, tested through tunnel, planned for next week release

@rithviknishad rithviknishad marked this pull request as ready for review September 1, 2023 13:05
@rithviknishad
Copy link
Member Author

weird that that tests are failing. but fine on my local

image

@vigneshhari vigneshhari merged commit 5357923 into master Sep 7, 2023
@vigneshhari vigneshhari deleted the consultation-verifiedby-user-relation branch September 7, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants