Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list and detail serializer to bed module #1447

Closed

Conversation

GeekGawd
Copy link
Contributor

@GeekGawd GeekGawd commented Jul 11, 2023

Proposed Changes

  • Add list and detail serializer to the bed module and remove the references of BedSerializer and ConsulationBedSerializer
  • Add tests for the changes
  • Add comment to remove BedSerializer and ConsultationBedSerializer when epic issue is resolved

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that ConsultationBedSerializer and BedSerializer are not being used they can be removed

I ran a coverage test and found out that we are missing validate functions in tests can you try to inporve coverage of those functions
here is the command to get coverage report

coverage run manage.py test --settings=config.settings.test --keepdb --parallel=4 && coverage combine && coverage html && open htmlcov/index.html

@GeekGawd GeekGawd force-pushed the list-detail-serializer-bed branch from bd00ebd to 4ac96d6 Compare July 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants