-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list and detail serializer to facility_asset module #1427
Add list and detail serializer to facility_asset module #1427
Conversation
@GeekGawd the changes look good, can you verify and remove the AssetSerializer from other places as well and for the tests you can add and validate more data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes requested
@sainak done please check |
@GeekGawd tests failing |
@sainak yep fixed it |
@GeekGawd resolve confilicts |
f4da1e3
to
a582812
Compare
737cd6d
to
0cac0c6
Compare
@sainak merged and fixed test cases |
Proposed Changes
Associated Issue
Part of ohcnetwork/care_fe#5492
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins