Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added recommend_discharge as action #1260

Merged
merged 6 commits into from
Oct 16, 2023
Merged

fix: added recommend_discharge as action #1260

merged 6 commits into from
Oct 16, 2023

Conversation

aeswibon
Copy link
Member

Feature Request

Proposed Changes

  • Removed recommended_discharge field from daily_round
  • Added DISCHARGE_RECOMMENDED as action

Associated PR

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@coronasafe/code-reviewers

@aeswibon aeswibon requested a review from a team as a code owner April 18, 2023 10:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

siddnikh
siddnikh approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@siddnikh siddnikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshhari vigneshhari requested review from rithviknishad and sainak and removed request for a team August 8, 2023 18:33
rithviknishad
rithviknishad approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-coder rebase the migrations

sainak
sainak requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

care/facility/migrations/0346_add_recommend_discharge_action.py Outdated Show resolved Hide resolved
care/facility/migrations/0346_add_recommend_discharge_action.py Outdated Show resolved Hide resolved
care/facility/models/daily_round.py Show resolved Hide resolved
rithviknishad
rithviknishad requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the tests CI failing

@nihal467 nihal467 mentioned this pull request Aug 21, 2023
Closed
@aeswibon aeswibon force-pushed the issue#5345 branch 2 times, most recently from dbfed16 to 6c567d9 Compare September 9, 2023 11:18
@aeswibon
Copy link
Member Author

aeswibon commented Sep 9, 2023

I have added the tests for Log update. This PR is ready for review

@aeswibon aeswibon added the done label Sep 9, 2023
@Ashesh3
Copy link
Member

Ashesh3 commented Sep 19, 2023

@cp-coder Can you resolve the merge conflicts?

sainak
sainak requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were some changes in tests so you need to create the required objects, refer other test

and revert changes in users/test_api and test_base

@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2829067) 59.11% compared to head (fc0a3ec) 59.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
+ Coverage   59.11%   59.50%   +0.39%     
==========================================
  Files         207      207              
  Lines       11264    11264              
  Branches     1599     1599              
==========================================
+ Hits         6659     6703      +44     
+ Misses       4405     4343      -62     
- Partials      200      218      +18
Files Coverage Δ
care/facility/api/serializers/daily_round.py 48.68% <100.00%> (+15.13%) ⬆️
care/facility/models/patient.py 94.84% <100.00%> (+0.02%) ⬆️
care/facility/models/daily_round.py 86.11% <0.00%> (+4.08%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

Functionality LGTM @sainak @rithviknishad @Ashesh3 can you review it

@rithviknishad rithviknishad requested a review from sainak October 3, 2023 05:04
@vigneshhari vigneshhari merged commit 2c4d207 into ohcnetwork:master Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddnikh siddnikh siddnikh approved these changes

@sainak sainak sainak approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aeswibon @Ashesh3 @nihal467 @rithviknishad @sainak @siddnikh @vigneshhari