refactor discharge summary endpoints #1252

sainak · 2023-04-14T10:56:24Z

Proposed Changes

update patient discharge summary
move discharge routes to consultation viewset as it is more related to consultation
discharge and discharge summary now require consultation id
discharge summary is now generated and stored on s3 as soon as the patient is discharged, and is fetched from s3 for email and preview

new summary fromat:
8b7a659a-d59e-4c8b-bb30-27f95b142ebb1681659555.pdf

@coronasafe/code-reviewers

Merge Checklist

Tests added/fixed
Update docs in /docs
Linting Complete

codecov-commenter · 2023-04-14T11:03:10Z

Codecov Report

Patch coverage: 37.57% and project coverage change: +0.23 🎉

Comparison is base (cd15b6e) 56.18% compared to head (2e85e0c) 56.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   56.18%   56.41%   +0.23%     
==========================================
  Files         195      195              
  Lines        9625     9658      +33     
  Branches     1615     1615              
==========================================
+ Hits         5408     5449      +41     
+ Misses       4162     4154       -8     
  Partials       55       55

Impacted Files	Coverage Δ
care/facility/api/viewsets/patient.py	`52.23% <25.00%> (+6.86%)`	⬆️
care/facility/static_data/icd11.py	`78.78% <25.00%> (-17.22%)`	⬇️
care/facility/tasks/patient/discharge_report.py	`36.36% <30.35%> (+7.19%)`	⬆️
care/facility/models/file_upload.py	`67.21% <30.76%> (-2.60%)`	⬇️
care/facility/api/viewsets/patient_consultation.py	`51.61% <40.00%> (-11.66%)`	⬇️
...e/facility/api/serializers/patient_consultation.py	`36.61% <44.44%> (+3.28%)`	⬆️
care/facility/models/patient_consultation.py	`93.42% <50.00%> (-2.42%)`	⬇️
care/facility/templatetags/filters.py	`40.90% <71.42%> (+14.24%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sainak · 2023-04-14T12:35:36Z

required for ohcnetwork/care_fe#5246

care/facility/api/serializers/patient_consultation.py

care/facility/api/viewsets/patient_consultation.py

vigneshhari · 2023-04-17T16:38:23Z

care/facility/api/viewsets/patient_consultation.py

+            if summary.upload_completed:
+                return Response(FileUploadRetrieveSerializer(summary).data)
+
+            if summary.created_date <= timezone.now() - timedelta(minutes=2):


What edge case are we solving here?

care/facility/tasks/patient/discharge_report.py

vigneshhari · 2023-04-17T16:41:27Z

care/facility/tasks/patient/discharge_report.py

+        associating_id=consultation.external_id,
+    ).first()
+
+    if file_db_entry is None:


So the patient only has one discharge summary object?

vigneshhari · 2023-04-17T16:43:16Z

care/facility/tasks/patient/discharge_report.py

+    if (
+        summary is not None
+        and not summary.upload_completed
+        and summary.created_date <= timezone.now() - timedelta(minutes=2)


should we maintain time restrictions in a system that is designed to be asynchronous?

vigneshhari · 2023-04-17T16:46:18Z

care/facility/tasks/patient/discharge_report.py

+            },
+            ExpiresIn=2 * 24 * 60 * 60,  # seconds
+        )
+    return signed_url


Where is this function used ?

…ed count (#1286) Add validation for current bed count to be LESSER than total bed count in FacilityCapacitySerializer

nihal467 · 2023-05-05T08:45:12Z

@sainak what is the status on this PR

* bump `isort` * bump `isort` in requirements * set isort version to 5.11.5

added workflow for lambda docker build

updated branch filter

…nto feat/discharge-summary

sonarqubecloud · 2023-05-09T16:49:45Z

SonarCloud Quality Gate failed.

6 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

rithviknishad · 2023-05-10T14:56:58Z

@vigneshhari @sainak just a cautionary reminder/note:

Upon merging #1247 the dischare_prescriptions and discharge_prn_prescriptions are no longer JSON fields but a separate Model.

rithviknishad · 2023-05-13T11:39:03Z

@sainak unable to download discharge summary. Am I missing some setup's to be done locally?

cc: @nihal467

refactor discharge summary endpoints

626a5e7

sainak requested a review from a team as a code owner April 14, 2023 10:56

fix some lint issues

04c9b94

sainak added the P1 High priority; urgent label Apr 14, 2023

sainak requested a review from khavinshankar April 14, 2023 11:00

sainak marked this pull request as draft April 14, 2023 11:12

hide url from footer

8dbaeac

sainak marked this pull request as ready for review April 14, 2023 11:21

return 404 if report is not yet generated

068516c

vigneshhari requested changes Apr 15, 2023

View reviewed changes

care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved

care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved

care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved

sainak added 2 commits April 16, 2023 18:37

remove print statements and use transaction blocks

67edad9

add more spacing and make values darker

20efcf8

sainak force-pushed the feat/discharge-summary branch from 49ab4f8 to 20efcf8 Compare April 16, 2023 13:23

fix lint issues

f081ca5

sainak requested a review from vigneshhari April 16, 2023 13:45

sainak added the waiting-for-review label Apr 16, 2023

sainak added 4 commits April 16, 2023 19:19

remove usage of builtin as variable names

7356f01

fix duplicate file entries on failure

61c646a

revert font size change in tables

5f12d42

use inbuilt execption to raise errors

5e0ca10

vigneshhari requested changes Apr 17, 2023

View reviewed changes

sainak linked an issue Apr 18, 2023 that may be closed by this pull request

Simplify the Discharge View by Converting it to a Serializer #1205

Closed

Enforce constraint on current bed count being lesser than the total b…

2ef9aea

…ed count (#1286) Add validation for current bed count to be LESSER than total bed count in FacilityCapacitySerializer

rithviknishad and others added 4 commits May 7, 2023 09:02

bump isort as pre-commit initialize fails with older version (#1289)

17632aa

* bump `isort` * bump `isort` in requirements * set isort version to 5.11.5

added workflow for lambda docker build

52d992c

Merge pull request #1290 from coronasafe/devops/lambda-changes

ecbd8cd

added workflow for lambda docker build

updated branch filter

30998e2

mathew-alex and others added 4 commits May 8, 2023 14:03

Merge pull request #1292 from coronasafe/devops/lambda-changes

cd15b6e

updated branch filter

Merge branch 'master' into feat/discharge-summary

8b07f90

Cleanup code

1bc995f

Merge branch 'feat/discharge-summary' of github.com:coronasafe/care i…

2e85e0c

…nto feat/discharge-summary

rithviknishad changed the base branch from master to med-admin-record May 16, 2023 07:35

rithviknishad merged commit e658eee into med-admin-record May 16, 2023

rithviknishad mentioned this pull request May 16, 2023

Download Discharge Summary, Medicine Administration Records and upgraded Prescriptions ohcnetwork/care_fe#5458

Merged

6 tasks

sainak mentioned this pull request May 20, 2023

Simplify the Discharge View by Converting it to a Serializer #1205

Closed

sainak deleted the feat/discharge-summary branch June 2, 2023 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor discharge summary endpoints #1252

refactor discharge summary endpoints #1252

sainak commented Apr 14, 2023 •

edited

Loading

codecov-commenter commented Apr 14, 2023 •

edited

Loading

sainak commented Apr 14, 2023

vigneshhari Apr 17, 2023

vigneshhari Apr 17, 2023

vigneshhari Apr 17, 2023

vigneshhari Apr 17, 2023

nihal467 commented May 5, 2023

sonarqubecloud bot commented May 9, 2023

rithviknishad commented May 10, 2023

rithviknishad commented May 13, 2023

refactor discharge summary endpoints #1252

refactor discharge summary endpoints #1252

Conversation

sainak commented Apr 14, 2023 • edited Loading

Proposed Changes

Merge Checklist

codecov-commenter commented Apr 14, 2023 • edited Loading

Codecov Report

sainak commented Apr 14, 2023

vigneshhari Apr 17, 2023

Choose a reason for hiding this comment

vigneshhari Apr 17, 2023

Choose a reason for hiding this comment

vigneshhari Apr 17, 2023

Choose a reason for hiding this comment

vigneshhari Apr 17, 2023

Choose a reason for hiding this comment

nihal467 commented May 5, 2023

sonarqubecloud bot commented May 9, 2023

rithviknishad commented May 10, 2023

rithviknishad commented May 13, 2023

sainak commented Apr 14, 2023 •

edited

Loading

codecov-commenter commented Apr 14, 2023 •

edited

Loading