Fix warning when deleting empty folders #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move private field up - Correct formatting for private field - Prefer to use readonly
ogxd
reviewed
Apr 7, 2024
|
Sorry for the (huge) delay, appart from indentation of StringUtility it looks good to me |
Co-authored-by: Olivier Giniaux <[email protected]>
I just merged your suggestion without testing. btw I've been maintaining my own fork due to your inactivity (so all this stuff has been well tested by our team). Happy to move back to yours if you want to add me as a collaborator, also fine with maintaining my own fork. Pretty sure they'll be at parity after this PR is merged. There is still more work to do here, the most egregious outstanding issue is #20. I'm not actively working on this rn, but vaguely plan to come back to it at some stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Closes #16
This was caused by a bug in Unity where an incorrect path was being passed to
OnWillCreateAsset. For folders the path for the meta file was given, instead of the actual folder path. Because the meta file is not an asset, its guid would be zero. When deleting the folder, the correct path is given.I also did a small tidy on
AssetProcessor.Note that I tested this change with @ogxd's refactor branch, and it has no conflicts. (See #22)