Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated traversal code -- needs proper testing #16

Open
wants to merge 10 commits into
base: dev-meld-2.0
Choose a base branch
from

Conversation

gklyne
Copy link

@gklyne gklyne commented Dec 8, 2020

Changes to the parameter/key names for defining a graph traversal, per oerc-music/meld-testing-ssi3#1 (issue set up as TODO in a different repo).

I've also changed the registerTraversal function to (a) log a message if any unrecognized parameter/key names are used (including the old names), and (b) if the old names are provided by a caller, to map them to the new parameter names.

I've checked that the code compiles/builds, and that hello-meld-2 and hello-meld-3 work with these changes. I'm raising this as a PR mainly to invite review and comments.

@gklyne
Copy link
Author

gklyne commented Dec 8, 2020

I've also run npm run build to create files in the lib/ subdirectory (compiled JSX, etc.), which accounts for the number of new files.

@gklyne
Copy link
Author

gklyne commented Dec 9, 2020

I've also added a log message if graph traversal encounters a non-JSON file

@gklyne
Copy link
Author

gklyne commented Dec 9, 2020

Bug fixes applied - branch now works with 'hello-meld-3', which does rudimentary graph traversal.

(At least, it does for me when run with a local copy of this code.)

@gklyne gklyne requested a review from DILewis January 5, 2021 15:48
@DILewis DILewis requested a review from musicog February 2, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant