[ADD] estate: Tutorial chapters #194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nape-odoo
changed the title
nape-odoo
changed the title
ushyme
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Good work 👍🏾, just a few remarks:
- There are some inconsistencies in the use of double and single quotes. We tend to use single quotes for technical strings and double quotes for user-facing strings.
- Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems. This remark goes for all the files here.
- For
<field>in views, the "string" attribute is optional if you want to use the same label defined in the field. The framework will automatically use the field's label, so you can omit the "string" attribute to reduce redundancy. However, you can specify the "string" attribute if you need to override the default label with a different value.
|
|
|
@nape-odoo I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands. |
ushyme
reviewed
Nov 20, 2024
nape-odoo
force-pushed
the
18.0-tutorial-nape
branch
from
9aa858b to
814a36c
Compare
nape-odoo
force-pushed
the
18.0-tutorial-nape
branch
from
a2bb0c2 to
eb327f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.