Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 5.1 and 5.2 #2

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat: support 5.1 and 5.2 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e386df6
feat: make this compile on ue5.1.1
odinn1984 Nov 13, 2023
cd839a4
feat: make this compile on ue5.2.1
odinn1984 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BlockadeLabsSkyboxAi/Source/BlockadeLabsSkyboxAi/Private/CustomMessageDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "CustomMessageDialog.h"

#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION == 0
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION <= 2

EAppReturnType::Type FCustomMessageDialog::Open(
EAppMsgCategory MessageCategory,
Expand Down
4 changes: 2 additions & 2 deletions BlockadeLabsSkyboxAi/Source/BlockadeLabsSkyboxAi/Public/CustomMessageDialog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION == 0
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION <= 2

enum class EAppMsgCategory : uint8
{
Expand All @@ -14,7 +14,7 @@ enum class EAppMsgCategory : uint8

struct FCustomMessageDialog : FMessageDialog
{
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION == 0
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION <= 2

static EAppReturnType::Type Open(
EAppMsgCategory MessageCategory,
Expand Down
5 changes: 3 additions & 2 deletions BlockadeLabsSkyboxAi/Source/SkyboxAiApi/Public/SKyboxAiHttpClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@

#include "CoreMinimal.h"

#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION == 3
#if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION >= 2
#include "HttpFwd.h"
#elif ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION == 0
#elif ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION <= 1
#include "Interfaces/IHttpRequest.h"
#endif

#include "JsonObjectConverter.h"
#include "Logging/MessageLog.h"
#include "SkyboxAiHttpClient.generated.h"

typedef TFunction<void(const FString &Body, int StatusCode, bool bConnectedSuccessfully)> FSkyboxAiHttpCallback;
Expand Down
2 changes: 1 addition & 1 deletion BlockadeLabsSkyboxAi/Source/SkyboxAiApi/SkyboxAiApi.Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public SkyboxAiApi(ReadOnlyTargetRules Target) : base(Target)

if (BuildVersion.TryRead(BuildVersion.GetDefaultFileName(), out Version))
{
if (Version.MajorVersion == 5 && Version.MinorVersion == 0)
if (Version.MajorVersion == 5 && Version.MinorVersion <= 1)
{
PrivateDependencyModuleNames.AddRange(
new string[]
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ There are many solutions for secret management, please use one of them if you wa
| Engine Version | Windows | Linux | OSX |
| -------------- | ------- | ----- | --- |
| **5.0** | YES | NO | NO |
| **5.1** | NO | NO | NO |
| **5.2** | NO | NO | NO |
| **5.1** | YES | NO | NO |
| **5.2** | YES | NO | NO |
| **5.3** | YES | NO | NO |

## Setting Up The Plugin
Expand Down