Fix repo #27
Open
Fix repo #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillC3
force-pushed
the
willc-fix-repo
branch
5 times, most recently
from
1a9195c
to
fd3a7ad
Compare
evb123
reviewed
Apr 11, 2024
| , COUNT(customers.customer_id) AS new_customer_count | ||
| FROM {{ ref('wh_customers') }} AS customers | ||
| GROUP BY DATE_TRUNC('MONTH', customers.first_order) | ||
| ORDER BY DATE_TRUNC('MONTH', customers.first_order) DESC |
There was a problem hiding this comment.
Oh ok ! Yes thinking about it that makes sense as whatever uses the model can order if needed?
There was a problem hiding this comment.
We never hardcode in 'order bys' in models (downstream process can do that if necessary) this is just the because of the added processing required.
Order bys that are part of window functions are okay ROW_NUMBER() OVER (PARTITION BY col1 ORDER BY col2)
evb123
reviewed
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.