Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hints phys equal #1745

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Hints phys equal #1745

wants to merge 5 commits into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 25, 2024 •
edited
Loading

Fix #1372

@hhugo hhugo mentioned this pull request Nov 25, 2024
Closed
@TyOverby
Copy link
Collaborator

There's a lot of unexpected changes in this PR, I think you may need to rebase it?

@hhugo
Copy link
Member Author

hhugo commented Nov 25, 2024

This PR is based on #1721

@hhugo hhugo marked this pull request as draft November 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Object.is instead of === to implement phys_equal
2 participants
@hhugo @TyOverby