-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge wasm_of_ocaml #1724
base: master
Are you sure you want to change the base?
Merge wasm_of_ocaml #1724
Conversation
Lib: use number_t in Typed_array as well
Lib: use number_t in yet a few more places
Fix typo in `caml_ba_get_3` bounds check
Fix implementation of caml_register_named_value
and directly use l##.hash; given Firefox' bug https://bugzilla.mozilla.org/show_bug.cgi?id=483304 is closed since 8+ years.
Add missing primitives
* added 'ellipse' method to canvasRenderingContext2D --------- Co-authored-by: Hugo Heuzard <[email protected]>
* Support for dialogElement * Added cancel and close events --------- Co-authored-by: Hugo Heuzard <[email protected]>
* Compiler: fix free variable for classes
Update to new JavaScript-Promise Integration API
Merge with js_of_ocaml master
I'm not sure what to do regarding the current issues. I don't think we can migrate issues across organizations. |
|
#1631 has been merged. Can you rebase/update this PR one more (final?) time |
Use JS String Builtins to convert ASCII OCaml strings to Javascript strings
Update examples
Merge with js_of_ocaml master
This reverts commit f428e0e.
|
||
- run: opam install conf-c++ | ||
# Otherwise, the next step fails reinstalling gcc while compiling | ||
# other packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing binaryen is pretty slow. I wonder if should not do it here and only do it in build-wasm_of_ocaml.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue is that dune build @all
will invoke wasm-merge
and wasm-opt
to build runtime/wasm/runtime.wasm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could cache binaryen, as is done in build-wasm_of_ocaml.yml
(description | ||
"Wasm_of_ocaml is a compiler from OCaml bytecode to WebAssembly. It makes it possible to run pure OCaml programs in JavaScript environment like browsers and Node.js") | ||
(depends | ||
(ocaml (and (>= 4.14) (< 5.3))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsoo is compatible with 5.3. What's missing for wasmoo ?
This aims to merge wasm_of_ocaml, currently hosted at https://github.com/ocaml-wasm/wasm_of_ocaml, back into this repo.
This is pending on Dune support ocaml/dune#11029. For now, Dune is pinned for the CI jobs.