Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge wasm_of_ocaml #1724

Open
wants to merge 555 commits into
base: master
Choose a base branch
from
Open

Merge wasm_of_ocaml #1724

wants to merge 555 commits into from

Conversation

OlivierNicole
Copy link
Contributor

@OlivierNicole OlivierNicole commented Oct 31, 2024

This aims to merge wasm_of_ocaml, currently hosted at https://github.com/ocaml-wasm/wasm_of_ocaml, back into this repo.

This is pending on Dune support ocaml/dune#11029. For now, Dune is pinned for the CI jobs.

vouillon and others added 30 commits August 1, 2024 12:26
Lib: use number_t in Typed_array as well
Lib: use number_t in yet a few more places
Fix typo in `caml_ba_get_3` bounds check
Fix implementation of caml_register_named_value
and directly use l##.hash;

given Firefox' bug https://bugzilla.mozilla.org/show_bug.cgi?id=483304
is closed since 8+ years.
* added 'ellipse' method to canvasRenderingContext2D
---------

Co-authored-by: Hugo Heuzard <[email protected]>
* Support for dialogElement

* Added cancel and close events

---------

Co-authored-by: Hugo Heuzard <[email protected]>
* Compiler: fix free variable for classes
@vouillon
Copy link
Member

Do you plan to migrate issues and PRs to this repo ?

I'm not sure what to do regarding the current issues. I don't think we can migrate issues across organizations.
There are not many opened PR. I think we can just create new PRs in this repo.

@vouillon
Copy link
Member

One thing that would help A LOT would be identify all packages broken by this PR and add an upper bound on the js_of_ocaml version (< 6.0) in the opam-repo. That would make releasing the next version much much easier.

See ocaml/opam-repository#26980

@hhugo hhugo mentioned this pull request Nov 28, 2024
@hhugo
Copy link
Member

hhugo commented Dec 2, 2024

#1631 has been merged. Can you rebase/update this PR one more (final?) time


- run: opam install conf-c++
# Otherwise, the next step fails reinstalling gcc while compiling
# other packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing binaryen is pretty slow. I wonder if should not do it here and only do it in build-wasm_of_ocaml.yml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that dune build @all will invoke wasm-merge and wasm-opt to build runtime/wasm/runtime.wasm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could cache binaryen, as is done in build-wasm_of_ocaml.yml

(description
"Wasm_of_ocaml is a compiler from OCaml bytecode to WebAssembly. It makes it possible to run pure OCaml programs in JavaScript environment like browsers and Node.js")
(depends
(ocaml (and (>= 4.14) (< 5.3)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsoo is compatible with 5.3. What's missing for wasmoo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.