Remove extensions (Eliom_{atom,openid}) #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilisp
force-pushed
the
kill-extensions
branch
from
e6ee84b
to
2fbad4d
Compare
|
@vasilisp Are you sure nobody uses these modules? |
|
I think server-to-server communications are useful. A high-level interface for fetching data with |
|
@dannywillems I am not saying that Atom, OpenID, and server-to-server are not useful. They are just out of context for Eliom and they can be easily maintained externally if anybody cares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocsigen/ocsigen-start#270 reminded me that we have some OpenID code in Eliom. We also have some stuff about Atom feeds, and a small module for doing server-to-server requests.
Does anyone remember about this stuff? I suggest we should remove them. They frequently get in the way when updating the APIs, and they can easily be used outside the Eliom tree if one is so motivated.