Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] do not discard errors #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] do not discard errors #192

wants to merge 1 commit into from

Conversation

bomgar
Copy link

@bomgar bomgar commented Mar 6, 2020

Some errors are silently discarded. This should not happen.

Changes:

  • exit code for all remote call errors
  • print error to stderr

@bomgar
Copy link
Author

bomgar commented May 20, 2020

@ochinchina i would appreciate some feedback on this. We currently use my fork to run things because scripting is hard without correct error codes.

@mriehl
Copy link

mriehl commented Jun 18, 2020

Any news on this?

@bomgar
Copy link
Author

bomgar commented Jan 18, 2021

@ochinchina could I get some feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bomgar @mriehl