Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor build fixes #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mbruggs
Copy link

@mbruggs mbruggs commented Mar 28, 2024

A few minor changes to ntplib versions and readme installation instructions.

mbruggs added 2 commits March 28, 2024 11:24
ntplib 0.3.3 is no longer available on pypi.
Small changes to correct the cloning instructions which also lead to
some whitespace trimming.
@mbruggs mbruggs force-pushed the minor-build-fixes branch from c73d450 to 4f8788f Compare March 28, 2024 14:50
@mbruggs
Copy link
Author

mbruggs commented Mar 28, 2024

Hello! Thanks very much for making these routines available. I tried to build the project today using the "OSX/Anaconda Instructions" section. It seems that ntplib 0.3.3 isn't available on pypi so I just bumped it to 0.3.4. Version 0.4.0 has also been released but I stuck to keeping the same minor version.

I also found that running the steps in the OSX/Anaconda section didn't actually install the mi-instrument library into the environment. This was simple enough to do by running

python setup.py install

from within the mi conda environment created. Should we also add this step into the instructions for completeness? I'm happy to add it to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant