Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] lsp (3 packages) (1.20.0) #26995

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

voodoos
Copy link
Contributor

@voodoos voodoos commented Nov 29, 2024

CHANGES:

Features

Fixes

CHANGES:

## Features

- Add custom
  [`ocamllsp/typeSearch`](/ocaml-lsp-server/docs/ocamllsp/typeSearch-spec.md) request (ocaml/ocaml-lsp#1369)

- Make MerlinJump code action configurable (ocaml/ocaml-lsp#1376)

- Add custom [`ocamllsp/jump`](/ocaml-lsp-server/docs/ocamllsp/merlinJump-spec.md) request (ocaml/ocaml-lsp#1374)

## Fixes

- Fix fd leak in running external processes for preprocessing (ocaml/ocaml-lsp#1349)

- Fix prefix parsing for completion of object methods (ocaml/ocaml-lsp#1363, fixes ocaml/ocaml-lsp#1358)

- Remove some duplicates in the `selectionRange` answers (ocaml/ocaml-lsp#1368)
@mseri
Copy link
Member

mseri commented Nov 29, 2024

A lower bound needs fixing:


#=== ERROR while compiling ocaml-lsp-server.1.20.0 ============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.2.1 | pinned(https://github.com/ocaml/ocaml-lsp/releases/download/1.20.0/lsp-1.20.0.tbz)
# path                 ~/.opam/5.2/.opam-switch/build/ocaml-lsp-server.1.20.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ocaml-lsp-server -j 39 @install
# exit-code            1
# env-file             ~/.opam/log/ocaml-lsp-server-7-d968f1.env
# output-file          ~/.opam/log/ocaml-lsp-server-7-d968f1.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -alert -unstable -w -58 -g -bin-annot -I ocaml-lsp-server/src/.ocaml_lsp_server.objs/byte -I /home/opam/.opam/5.2/lib/base -I /home/opam/.opam/5.2/lib/chrome-trace -I /home/opam/.opam/5.2/lib/csexp -I /home/opam/.opam/5.2/lib/dune-build-info -I /home/opam/.opam/5.2/lib/dune-rpc -I /home/opam/.opam/5.2/lib/dune-rpc/private -I /home/opam/.opam/5.2/lib/dyn -I /home/opam/.opam/5.2/lib/fiber -I /home/opam/.opam/5.2/lib/jsonrpc -I /home/opam/.opam/5.2/lib/lsp -I /home/opam/.opam/5.2/lib/merlin-lib/analysis -I /home/opam/.opam/5.2/lib/merlin-lib/commands -I /home/opam/.opam/5.2/lib/merlin-lib/dot_protocol -I /home/opam/.opam/5.2/lib/merlin-lib/extend -I /home/opam/.opam/5.2/lib/merlin-lib/kernel -I /home/opam/.opam/5.2/lib/merlin-lib/ocaml_merlin_specific -I /home/opam/.opam/5.2/lib/merlin-lib/ocaml_parsing -I /home/opam/.opam/5.2/lib/merlin-lib/ocaml_typing -I /home/opam/.opam/5.2/lib/merlin-lib/ocaml_utils -I /home/opam/.opam/5.2/lib/merlin-lib/query_commands -I /home/opam/.opam/5.2/lib/merlin-lib/query_protocol -I /home/opam/.opam/5.2/lib/merlin-lib/utils -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/ocamlc-loc -I /home/opam/.opam/5.2/lib/ocamlformat-rpc-lib -I /home/opam/.opam/5.2/lib/ordering -I /home/opam/.opam/5.2/lib/pp -I /home/opam/.opam/5.2/lib/ppx_yojson_conv_lib -I /home/opam/.opam/5.2/lib/re -I /home/opam/.opam/5.2/lib/spawn -I /home/opam/.opam/5.2/lib/stdune -I /home/opam/.opam/5.2/lib/stdune/filesystem_stubs -I /home/opam/.opam/5.2/lib/xdg -I /home/opam/.opam/5.2/lib/yojson -I lsp-fiber/src/.lsp_fiber.objs/byte -I ocaml-lsp-server/vendor/cmarkit/.cmarkit.objs/byte -I ocaml-lsp-server/vendor/lev-fiber-csexp/.lev_fiber_csexp.objs/byte -I ocaml-lsp-server/vendor/lev-fiber/.lev_fiber.objs/byte -I ocaml-lsp-server/vendor/lev/.lev.objs/byte -I vendor/odoc-parser/src/.odoc_parser.objs/byte -no-alias-deps -open Ocaml_lsp_server__ -o ocaml-lsp-server/src/.ocaml_lsp_server.objs/byte/ocaml_lsp_server__Import.cmo -c -impl ocaml-lsp-server/src/import.ml)
# File "ocaml-lsp-server/src/import.ml", line 33, characters 17-18:
# 33 |         Int.incr i
#                       ^
# Error: This expression has type "int/2 Base.ref" = "int/2 Stdlib.ref"
#        but an expression was expected of type
#          "Base.Int.t Base__.Import.ref" = "Base.Int.t Caml.ref"
#        File "_none_", line 1:
#          Definition of type "int/2"
# (cd _build/default/ocaml-lsp-server/vendor/lev && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -pthread -D_FILE_OFFSET_BITS=64 -g -I /home/opam/.opam/5.2/lib/ocaml -I /home/opam/.opam/5.2/lib/ocaml/unix -o ev.o -c ev.c)
# submodules/lev/lev/vendor/ev.c:2143:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'

voodoos and others added 3 commits November 29, 2024 16:15
CHANGES:

## Features

- Add custom
  [`ocamllsp/typeSearch`](/ocaml-lsp-server/docs/ocamllsp/typeSearch-spec.md) request (ocaml/ocaml-lsp#1369)

- Make MerlinJump code action configurable (ocaml/ocaml-lsp#1376)

- Add custom [`ocamllsp/jump`](/ocaml-lsp-server/docs/ocamllsp/merlinJump-spec.md) request (ocaml/ocaml-lsp#1374)

## Fixes

- Fix fd leak in running external processes for preprocessing (ocaml/ocaml-lsp#1349)

- Fix prefix parsing for completion of object methods (ocaml/ocaml-lsp#1363, fixes ocaml/ocaml-lsp#1358)

- Remove some duplicates in the `selectionRange` answers (ocaml/ocaml-lsp#1368)
@voodoos
Copy link
Contributor Author

voodoos commented Nov 29, 2024

Thanks @mseri. Should be good with base >= 0.16.0.

(I also added a release compatible with 4.14, so we should wait for the CI)

@avsm avsm merged commit 6c49f0f into ocaml:master Nov 29, 2024
3 checks passed
@avsm
Copy link
Member

avsm commented Nov 29, 2024

All passed the CI! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take class methods into account for suggestions
3 participants