release of ppx_deriving.4.3 #14258
Merged
release of ppx_deriving.4.3 #14258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4.3 Changelog: * use Format through Ppx_deriving_runtime to avoid deprecation warning for users of JaneStreet Base (Stephen Bastians and Gabriel Scherer, review by whitequark) * silence a ambiguous-field warning (41) in generated code ocaml-ppx/ppx_deriving#163 (Étienne Millon, review by Gabriel Scherer) * use dune ocaml-ppx/ppx_deriving#170 (Rudi Grinberg, Jérémie Dimino) * silence an unused-value warning for show ocaml-ppx/ppx_deriving#179 (Nathan Rebours) First attempt: ocaml#13652 The second attempt incorporated minor changes to the opam file (no other change to the ppx_deriving pre-release), and occurred after the revdeps failures of the first attempt have been reviewed and fixed. Second attempt: ocaml#14018 Kate helped investigate the few failures remaining with the second attempt, and provided the motivation for finally getting the release out -- opam-repository will always be in an imperfect state... Thanks!
☀️ All lint checks passed e8bd5f4
☀️ Installability check (11305 → 11308)
|
|
Travis fails on 4.02; this is a known issue with 4.3, but it only affects the tests. We merged a PR in master that fixed all 4.02 build issues. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.3 Changelog:
for users of JaneStreet Base
(Stephen Bastians and Gabriel Scherer, review by whitequark)
map plugin: add a type annotation to avoid warning 41 ocaml-ppx/ppx_deriving#163
(Étienne Millon, review by Gabriel Scherer)
Port to Dune ocaml-ppx/ppx_deriving#170
(Rudi Grinberg, Jérémie Dimino)
Suppress warning 32 for show ocaml-ppx/ppx_deriving#179
(Nathan Rebours)
First attempt: #13652
The second attempt incorporated minor changes to the opam file (no
other change to the ppx_deriving pre-release), and occurred after the
revdeps failures of the first attempt have been reviewed and fixed.
Second attempt: #14018
Kate helped investigate the few failures remaining with the second
attempt, and provided the motivation for finally getting the release
out -- opam-repository will always be in an imperfect state... Thanks!