Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppxlib 5.2 trunk-support needs value_constraint support #423

Closed
avsm opened this issue Jun 2, 2023 · 6 comments
Closed

ppxlib 5.2 trunk-support needs value_constraint support #423

avsm opened this issue Jun 2, 2023 · 6 comments

Comments

@avsm
Copy link

avsm commented Jun 2, 2023

Since ocaml/ocaml@ba57d5212a, the trunk-support branch fails to build due to ocaml/ocaml#12188 changing how coercion on value bindings work.

@pitag-ha
Copy link
Member

pitag-ha commented Jun 2, 2023

I'm working on that. Adding support for value binding coercions was straight-forward, but by doing so, I've noticed that our migrations of value binding constraints already seem to be wrong, so it's taking a bit longer. I can see if I already push something that compiles on 5.1 and 5.2 today, even if it won't do the right migrations. That would also be helpful for @Sudha247 and @shym, wouldn't it?

@pitag-ha
Copy link
Member

pitag-ha commented Jun 2, 2023

@avsm, @Sudha247, @shym and @nojb, you can pin to panglesd:fix-418, if you already need 5.1.0~alpha2 or 5.2.0+trunk support (now that I've said that, I won't force push to it anymore). We'll probably merge the branch beginning of next week some time soon, so then our trunk-support will be working again.

@Sudha247
Copy link

Sudha247 commented Jun 2, 2023

Thanks! cc @punchagan relevant for ocaml-bench/sandmark#453.

@avsm
Copy link
Author

avsm commented Jun 4, 2023

@pitag-ha your speed of response is faster than light! Thanks very much indeed -- your branch above unblocked me while testing the ppc64/ocaml5 PR.

@shym
Copy link
Contributor

shym commented Jun 5, 2023

@pitag-ha I had a quick glance at that branch (probably too short to count as proper review, but still), I really like its testing, very nice!

@pitag-ha
Copy link
Member

The trunk-support branch is now compatible both with ocaml.5.1.0~alpha2 and with ocaml.5.2.0+trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants