-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppxlib 5.2 trunk-support needs value_constraint support #423
Comments
I'm working on that. Adding support for value binding coercions was straight-forward, but by doing so, I've noticed that our migrations of value binding constraints already seem to be wrong, so it's taking a bit longer. I can see if I already push something that compiles on 5.1 and 5.2 today, even if it won't do the right migrations. That would also be helpful for @Sudha247 and @shym, wouldn't it? |
@avsm, @Sudha247, @shym and @nojb, you can pin to panglesd:fix-418, if you already need |
Thanks! cc @punchagan relevant for ocaml-bench/sandmark#453. |
@pitag-ha your speed of response is faster than light! Thanks very much indeed -- your branch above unblocked me while testing the ppc64/ocaml5 PR. |
@pitag-ha I had a quick glance at that branch (probably too short to count as proper review, but still), I really like its testing, very nice! |
The |
Since ocaml/ocaml@ba57d5212a, the trunk-support branch fails to build due to ocaml/ocaml#12188 changing how coercion on value bindings work.
The text was updated successfully, but these errors were encountered: