Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid needless shrinking and refactor fragile STM tests #499

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Avoid needless shrinking and refactor fragile STM tests #499

merged 11 commits into from
Dec 20, 2024

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Dec 20, 2024

Fixes #498

This PR

  • removes needless reruns during shrinking in Weak and Weak Hashset STM tests, as these can cause excessive shrinking runs
  • refactors STM tests for Weak, Weak Hashset, and Ephemeron (all 3 fragile wrt. GC state) into specifications and separate executable test files, allowing each to start off from a fresh heap

jmid added 11 commits December 20, 2024 11:25
@jmid
Disable cmd shrinking in src/weak/stm_tests.ml
23ebf6a
@jmid
Disable cmd shrinking in src/weak/stm_tests_hashset.ml
3707f92
@jmid
Factor WeakConf into a separate module
77a5b3b
@jmid
Factor Weak STM tests into separate executable tests to reduce GC int…
51efb80 
…erference
@jmid
Factor stm_tests_spec_hashset into a separate module
acd2fa5
@jmid
Rename stm_tests_spec_weak -> src/weak/stm_tests_weak_spec
64716fd
@jmid
Rename src/weak/stm_tests_spec_hashset -> src/weak/stm_tests_hashset_…
1c6cd14 
…spec
@jmid
Factor Weak Hashset STM tests into separate executable tests to reduc…
dc5ffaa 
…e GC interference
@jmid
Rename STM Weak test files for consistency
41d807e
@jmid
Factor src/ephemeron/stm_tests_spec into a separate module
6f557e5
@jmid
Factor Ephemeron STM tests into separate executable tests to reduce G…
b459032 
…C interference
@jmid
Copy link
Collaborator Author

jmid commented Dec 20, 2024

CI summary: all 33 workflows green

@jmid jmid merged commit c13ea8c into main Dec 20, 2024
33 checks passed
@jmid jmid deleted the avoid-needless-shrinking branch December 20, 2024 14:44
@jmid
Copy link
Collaborator Author

jmid commented Dec 20, 2024

CI summary for merge to main: all 34 workflows passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive shrinking times in STM Weak test parallel
1 participant
@jmid